Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for release v0.8.0 #327

Merged
merged 8 commits into from
Oct 2, 2023
Merged

Changes for release v0.8.0 #327

merged 8 commits into from
Oct 2, 2023

Conversation

dreamtalen
Copy link
Contributor

No description provided.

tushartathgur and others added 6 commits October 2, 2023 15:16
@tushartathgur @dreamtalen
Changing the datatype for flowEndSecondsFromSourceNode and flowEndSec…
174f4d7 
…ondsFromDestinationNode (vmware#320)

flowEndSecondsFromDestinationNode and flowEndSecondsFromDestinationNode
are changed to the type DateTimesecond

Signed-off-by: Tushar Tathgur <[email protected]>
Co-authored-by: Tushar Tathgur <[email protected]>
@antoninbas @dreamtalen
Improve handling of string IEs (vmware#322)
152e5e9 
* Use the copy built-in to copy string bytes to buffer, instead of
  copying bytes one-by-one with a for loop. This is more efficient
  (confirmed with new Benchmark functions) and more correct (in case
  the string includes UTF-8 characters which use more than 1 byte).
* Increase max string length from 65,534 to 65,535 (as per the
  IPFIX RFC 7011).

Signed-off-by: Antonin Bas <[email protected]>
@tushartathgur @dreamtalen
Adding L7 visibility fields (vmware#315)
b141f8b 
* L7 Visibility support in Antrea

Signed-off-by: Tushar Tathgur <[email protected]>

* Replaced isL7 bool with l7ProtocolName string

Signed-off-by: Tushar Tathgur <[email protected]>

---------

Signed-off-by: Tushar Tathgur <[email protected]>
Co-authored-by: Tushar Tathgur <[email protected]>
@antoninbas @dreamtalen
Avoid error logs in BenchmarkMultipleExportersToCollector (vmware#323)
6d01e0e 
* Gracefully shutdown exporter connections before stopping collector.
* Do not log an error for graceful client shutdown (EOF error).

Signed-off-by: Antonin Bas <[email protected]>
@antoninbas @dreamtalen
Fix aggregation bug for throughput common fields (vmware#324)
e89e737 
Just like for stats, throughput common fields should only be updated for
the "latest" record (based on "flowEndSeconds").

This bug explains why the TestCollectorToIntermediate integration test
has been flaky for a long time. In some cases, the record from the
destination was processed before the record from the source (we have 2
aggregation workers, so records are not guaranteed to be processed in
the order in which they are received). While the destination record has
a larger "flowEndSeconds", the "throughput" and "reverseThroughput"
common elements were overriden by values from the source record.

Signed-off-by: Antonin Bas <[email protected]>
@antoninbas @dreamtalen
Improvements in integration tests (vmware#325)
06f6636 
* Use more meaningful byte counts in test records (count and
  reverseCount have no reason to be the same).
* Generate test data packets automatically using a function, instead of
  having to generate packet data manually.
* Add integration build tag for linters

Signed-off-by: Antonin Bas <[email protected]>
@dreamtalen dreamtalen mentioned this pull request Oct 2, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #327 (ce218e6) into release-0.8.0 (9b27303) will decrease coverage by 0.02%.
The diff coverage is 72.34%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-0.8.0     #327      +/-   ##
=================================================
- Coverage          73.54%   73.53%   -0.02%     
=================================================
  Files                 18       19       +1     
  Lines               2786     2800      +14     
=================================================
+ Hits                2049     2059      +10     
- Misses               572      574       +2     
- Partials             165      167       +2
Flag Coverage Δ
integration-tests 51.53% <76.47%> (+0.14%) ⬆️
unit-tests 72.53% <72.34%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/exporter/msg.go 100.00% <100.00%> (ø)
pkg/intermediate/aggregate.go 72.60% <100.00%> (+0.05%) ⬆️
pkg/registry/registry_antrea.go 100.00% <100.00%> (ø)
pkg/collector/process.go 86.03% <0.00%> (ø)
pkg/exporter/process.go 56.90% <75.00%> (-2.23%) ⬇️
pkg/collector/tcp.go 65.43% <75.00%> (+1.32%) ⬆️
pkg/entities/ie.go 52.39% <18.18%> (-0.54%) ⬇️

@antoninbas
Copy link
Member

Your release-0.8.0 branch is not correct. It should be the same as main right now?

@dreamtalen
Copy link
Contributor Author

Your release-0.8.0 branch is not correct. It should be the same as main right now?

I got your point, it seems that our release workflow differs from that of Antrea.
I created the release-0.8.0 branch based on release-0.7.0 and cherry-picked commits for this release.
Some example PR of previous releases:
#299
#309

@antoninbas
Copy link
Member

@dreamtalen ok, I'll let @heanlan review the PR then :)

@heanlan
Copy link
Contributor

heanlan commented Oct 2, 2023

@dreamtalen could you check the difference between your branch and the main branch by running git diff? release-0.7.0 was created based off the main branch at that time. So I suppose there should be no differences for your branch and the main 🤔

@dreamtalen
Copy link
Contributor Author

@dreamtalen could you check the difference between your branch and the main branch by running git diff? release-0.7.0 was created based off the main branch at that time. So I suppose there should be no differences for your branch and the main 🤔

Yes, there are no differences except CHANGELOG.md and VERSION file

heanlan
heanlan reviewed Oct 2, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@dreamtalen
Update CHANGELOG for v0.8.0
07e546a 
Signed-off-by: Yongming Ding <[email protected]>
@dreamtalen
Update VERSION
ce218e6 
Signed-off-by: Yongming Ding <[email protected]>
heanlan
heanlan approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@heanlan heanlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreamtalen dreamtalen merged commit 4f4d653 into vmware:release-0.8.0 Oct 2, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heanlan heanlan heanlan approved these changes

@antoninbas antoninbas Awaiting requested review from antoninbas

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dreamtalen @antoninbas @heanlan @vmwclabot @tushartathgur