Improve memory performance of collector #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before change: After change: |
|
@heanlan @dreamtalen let me know if you think this is not a correct change (functionality-wise) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
- Coverage 73.25% 72.87% -0.39%
==========================================
Files 19 19
Lines 2808 2831 +23
==========================================
+ Hits 2057 2063 +6
- Misses 581 599 +18
+ Partials 170 169 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Avoid unnecessary slice creation when adding a record to a set. We implement this change for both data record and template records, but in practice most of the gains will come from data records. Memory allocations (in bytes) are reduced by around 15% for BenchmarkCollector. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
avoid-unnecessary-slice-creation-when-adding-record-to-set
branch
from
b3d6e26
to
6d7c889
Compare
heanlan
approved these changes
Oct 10, 2023
Since it's a public API of the library, and there was no strong reason to remove it, I just kept it |
antoninbas
deleted the
avoid-unnecessary-slice-creation-when-adding-record-to-set
branch
heanlan
pushed a commit
to heanlan/go-ipfix
that referenced
this pull request
Dec 7, 2023
Avoid unnecessary slice creation when adding a record to a set. We implement this change for both data record and template records, but in practice most of the gains will come from data records. Memory allocations (in bytes) are reduced by around 15% for BenchmarkCollector. Signed-off-by: Antonin Bas <[email protected]>
heanlan
pushed a commit
that referenced
this pull request
Dec 7, 2023
Avoid unnecessary slice creation when adding a record to a set. We implement this change for both data record and template records, but in practice most of the gains will come from data records. Memory allocations (in bytes) are reduced by around 15% for BenchmarkCollector. Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary slice creation when adding a record to a set. We implement this change for both data record and template records, but in practice most of the gains will come from data records.
Memory allocations (in bytes) are reduced by around 15% for BenchmarkCollector.