Fix #1173

[amandahla]

I changed to get all VMs but it's a little bit slow because I'm retrieving the config.template property for each VM otherwise will count Templates as VM too.

[dougm]

Thanks @amandahla , using ContainerView would speed things up, do you want to try that? For an example, see:

govmomi/examples/virtualmachines/main.go

Lines 45 to 58 in e560c7b

	// Create view of VirtualMachine objects
	m := view.NewManager(c.Client)
	v, err := m.CreateContainerView(ctx, c.ServiceContent.RootFolder, []string{"VirtualMachine"}, true)
	if err != nil {
	log.Fatal(err)
	}
	defer v.Destroy(ctx)
	// Retrieve summary property for all machines
	// Reference: http://pubs.vmware.com/vsphere-60/topic/com.vmware.wssdk.apiref.doc/vim.VirtualMachine.html
	var vms []mo.VirtualMachine
	err = v.Retrieve(ctx, []string{"VirtualMachine"}, []string{"summary"}, &vms)

[amandahla]

@dougm Much faster, thanks! Do you think is necessary to change others too to not use finder?

[dougm]

@amandahla looking good, can you also remove "WIP" from the commit message?

There might be other places where ContainerView would be better. In general, ContainerView is best when you want all instances, Finder is better for specific/subset of instances. I think Finder could also be optimized to use ContainerView underneath in the * pattern case at least.

[amandahla]

@dougm sure, done!

Thanks!

[dougm]

@amandahla sorry I just realized I had started a review with these 2 comments, but hadn't actually submitted the review with my commit message update request.

[amandahla]

@dougm no problem, thanks for the comments.

[dougm]

Great, thanks again @amandahla

[amandahla]

Glad to help! :-)