Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appliance log forwarding config handler and govc verb #1994

Merged
merged 4 commits into from
May 30, 2020

Conversation

fdawg4l
Copy link
Contributor

@fdawg4l fdawg4l commented May 26, 2020

Appliance logging config can be retrieved via the VAPI REST
endpoint. The govc output is as follows.

$ govc appliance.logging.forwaring
Hostname:  10.186.54.118
Port:      5480
Protocol:  TLS
Hostname:  2.2.2.2
Port:      9999
Protocol:  TLS

Appliance logging config can be retrieved via the VAPI REST
endpoint.  The govc output is as follows.

```
$ govc appliance.logging.forwaring
Hostname:  10.186.54.118
Port:      5480
Protocol:  TLS
Hostname:  2.2.2.2
Port:      9999
Protocol:  TLS
```
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fdawg4l , a few cosmetic suggestions

govc/appliance/logging/forwarding.go Outdated Show resolved Hide resolved
govc/appliance/logging/forwarding.go Outdated Show resolved Hide resolved
govc/appliance/logging/forwarding.go Outdated Show resolved Hide resolved
vapi/appliance/logging/forwarding.go Outdated Show resolved Hide resolved
vapi/appliance/logging/forwarding.go Outdated Show resolved Hide resolved
vapi/appliance/logging/forwarding.go Outdated Show resolved Hide resolved
vapi/appliance/logging/forwarding.go Outdated Show resolved Hide resolved
govc/appliance/logging/forwarding.go Outdated Show resolved Hide resolved
govc/appliance/logging/forwarding.go Outdated Show resolved Hide resolved
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @fdawg4l !

@dougm dougm merged commit aa97c4d into vmware:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants