-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: defining of priorityClassName and add ServiceMonitor in helm chart #102
Conversation
747fc71
to
02540c8
Compare
/assign @jvassev |
@EVILRUSSIAN, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@EVILRUSSIAN, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@jvassev ? |
@EVILRUSSIAN Can you please add the DCO as suggested by the bot. Thanks! |
@gautam2187 |
@@ -0,0 +1,22 @@ | |||
{{- if .Values.serviceMonitor.enabled }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EVILRUSSIAN should we also check for prometheusEnabled here with serviceMonitor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. If prometheusOperator is not installed, then CRD ServiceMonitor will not be defined in cluster, and you will get an error
error: unable to recognize "ServiceMonitor.yaml": no matches for kind "ServiceMonitor" in version "monitoring.coreos.com/v1
@EVILRUSSIAN I think the bot is expecting "Signed-off-by: John Doe [email protected]" in the commit message. |
…perator Signed-off-by: Ruslan Gozgeshev <[email protected]>
@EVILRUSSIAN, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@EVILRUSSIAN, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Ruslan Gozgeshev <[email protected]>
@gautam2187 all check have passed |
This PR makes avaiable defining priorityClassName in daemonSet of kube-fluentd-operator in helm chart.
And it adds ServiceMonitor for supporting of Prometheus Operator
closes #99
closes #100