Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: defining of priorityClassName and add ServiceMonitor in helm chart #102

Merged
merged 2 commits into from
May 13, 2020

Conversation

acceptMyPR
Copy link
Contributor

@acceptMyPR acceptMyPR commented Feb 27, 2020

This PR makes avaiable defining priorityClassName in daemonSet of kube-fluentd-operator in helm chart.
And it adds ServiceMonitor for supporting of Prometheus Operator

closes #99
closes #100

@acceptMyPR
Copy link
Contributor Author

/assign @jvassev

@vmwclabot
Copy link
Member

@EVILRUSSIAN, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@EVILRUSSIAN, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@acceptMyPR
Copy link
Contributor Author

@jvassev ?

@gautam2187
Copy link
Contributor

@EVILRUSSIAN Can you please add the DCO as suggested by the bot.

Thanks!

@acceptMyPR
Copy link
Contributor Author

@gautam2187
I don't understand what i need to do. This PR has 2 commits and all commits are Signed-off

@@ -0,0 +1,22 @@
{{- if .Values.serviceMonitor.enabled }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EVILRUSSIAN should we also check for prometheusEnabled here with serviceMonitor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If prometheusOperator is not installed, then CRD ServiceMonitor will not be defined in cluster, and you will get an error
error: unable to recognize "ServiceMonitor.yaml": no matches for kind "ServiceMonitor" in version "monitoring.coreos.com/v1

@gautam2187
Copy link
Contributor

@EVILRUSSIAN I think the bot is expecting "Signed-off-by: John Doe [email protected]" in the commit message.

@vmwclabot
Copy link
Member

@EVILRUSSIAN, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@EVILRUSSIAN, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Ruslan Gozgeshev <[email protected]>
@acceptMyPR
Copy link
Contributor Author

@gautam2187 all check have passed

@gautam2187 gautam2187 merged commit eb86597 into vmware:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support generating of ServiceMonitor Support of custom priorityClassName
3 participants