Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload Configuration only when a pod matching the label set in mounted-file is created or deleted #347

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

huskykurt
Copy link
Contributor

According to the issue comments (comment1, comment2) the existing solution caused too many configuration reloads.
This is because the configuration reload occurred whenever every pod was created (or deleted). So it is not affordable for a large cluster.
So, make the configuration reload only when a pod with the label set in the mounted-file is created (or deleted).

@huskykurt
Copy link
Contributor Author

Hello @javiercri. How do I get a review for this PR? I looked at the CLA FAQ and they said that if I send a PR, I will receive a comment requesting the CLA, but there is no comment.

@javiercri
Copy link
Contributor

First sorry for the late reply.
Could you fix the conflicts here @huskykurt, and I can approve it.
Thanks in advance!

@vmwclabot
Copy link
Member

@huskykurt, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@huskykurt, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@huskykurt
Copy link
Contributor Author

First sorry for the late reply. Could you fix the conflicts here @huskykurt, and I can approve it. Thanks in advance!

That's OK. I fixed the conflicts.

@javiercri javiercri self-requested a review December 15, 2022 08:21
Copy link
Contributor

@javiercri javiercri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javiercri javiercri merged commit b021e3a into vmware:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants