-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload Configuration only when a pod matching the label set in mounted-file is created or deleted #347
Conversation
Signed-off-by: vkadi <[email protected]>
) Signed-off-by: huskykurt <[email protected]>
Hello @javiercri. How do I get a review for this PR? I looked at the CLA FAQ and they said that if I send a PR, I will receive a comment requesting the CLA, but there is no comment. |
First sorry for the late reply. |
@huskykurt, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: huskykurt <[email protected]>
@huskykurt, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
That's OK. I fixed the conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
According to the issue comments (comment1, comment2) the existing solution caused too many configuration reloads.
This is because the configuration reload occurred whenever every pod was created (or deleted). So it is not affordable for a large cluster.
So, make the configuration reload only when a pod with the label set in the mounted-file is created (or deleted).