Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix reloader endpoint from post to get #383

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix: fix reloader endpoint from post to get #383

merged 1 commit into from
Jun 5, 2023

Conversation

slimm609
Copy link
Contributor

@slimm609 slimm609 commented Jun 5, 2023 •
edited
Loading

  • fix reloader endpoint from post to get
  • fix linting and test errors
  • reduce time for sleep to check more often
  • add skip_refresh_on_startup to support graceful reload as documented

@slimm609 slimm609 force-pushed the fix_reloader_post_get branch 2 times, most recently from 3f2b3af to 62e1518 Compare June 5, 2023 14:04
viveksyngh
viveksyngh approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@viveksyngh viveksyngh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmwclabot
Copy link
Member

@slimm609, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@slimm609
fix: fix reloader endpoint from post to get
dc1dc80 
- fix reloader endpoint from post to get
- fix linting and test errors
- reduce time for sleep to check more often
- add skip_refresh_on_startup to support gracefulReload

Signed-off-by: Brian Davis <[email protected]>
@slimm609 slimm609 merged commit 026acf6 into main Jun 5, 2023
@slimm609 slimm609 deleted the fix_reloader_post_get branch June 5, 2023 15:22
lynn-e pushed a commit to lynn-e/kube-fluentd-operator that referenced this pull request Jun 27, 2023
@slimm609 @lynn-e
fix: fix reloader endpoint from post to get (vmware#383)
c783e0c 
- fix reloader endpoint from post to get
- fix linting and test errors
- reduce time for sleep to check more often
- add skip_refresh_on_startup to support gracefulReload

Signed-off-by: Brian Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erismaster erismaster erismaster approved these changes

@viveksyngh viveksyngh viveksyngh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slimm609 @vmwclabot @erismaster @viveksyngh