-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support go templates in config sources #426
Conversation
@luisdavim, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
b1251e4
to
d0abcd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes requested, otherwise looks good.
d0abcd8
to
c79ca92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
c79ca92
to
2a829b4
Compare
fixes #37 This allows the config sources, like ConfigMaps to be `go` templates. All the functions from sprig lib are supported, there's also a k8sLookup function to get values from k8s objects, and you can access environment variables from the template under .Env object. Signed-off-by: Luis Davim <[email protected]>
2a829b4
to
619a15f
Compare
discussed internally to adding a label to the secret to make it opt-in to be allowed to get data from the secret to reduce the risk of reading secrets not intended for KFO usage. |
@luisdavim, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
cd41ed8
to
e106880
Compare
e106880
to
8323de8
Compare
Signed-off-by: Luis Davim <[email protected]>
8323de8
to
aafd349
Compare
fixes #37
This allows the config sources, like ConfigMaps to be
go
templates. All the functions from sprig lib are supported,there's also a k8sLookup function to get values from k8s objects, and you can access environment variables from the template under .Env object.