Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytests: Add conftest.py and other tests #73

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

prashant1221
Copy link
Contributor

@prashant1221 prashant1221 commented Aug 26, 2024

conftest.py contain common fixtures to setup and teardown.
We use them wherever feasible

Added Configurations and Hardware section tests in tests_all_configs.
It tests the keys present under those section in our config file.

pytest/test_raw_image_option.py checks .img if provided instead
of vmdk should still work.
After that it matches values for the same in ovf and our yaml.

Copy link
Contributor

@oliverkurth oliverkurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, please add comments to your code, explaining what is tested.

pytest/test_raw_image_option.py Outdated Show resolved Hide resolved
pytest/test_raw_image_option.py Outdated Show resolved Hide resolved
pytest/test_raw_image_option.py Outdated Show resolved Hide resolved
conftest.py contain common fixtures to setup and teardown.
We use them wherever feasible

Added Configurations and Hardware section tests in tests_all_configs.
It tests the keys present under those section in our config file.

pytest/test_raw_image_option.py checks .img if provided instead
of vmdk should still work.
After that it matches values for the same in ovf and our yaml.
@prashant1221 prashant1221 reopened this Sep 17, 2024
@prashant1221 prashant1221 marked this pull request as ready for review September 17, 2024 08:31
@prashant1221 prashant1221 changed the title pytests: Add test for raw_image option pytests: Add conftest.py and other tests Sep 17, 2024
@oliverkurth oliverkurth merged commit f388e67 into vmware:master Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants