Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-core: Support Python 3.10 #528

Merged
merged 6 commits into from
Nov 22, 2021
Merged

vdk-core: Support Python 3.10 #528

merged 6 commits into from
Nov 22, 2021

Conversation

gageorgiev
Copy link
Contributor

@gageorgiev gageorgiev commented Nov 17, 2021

This change makes it so vdk-core supports Python 3.10.
Addresses #390

Signed-off-by: gageorgiev [email protected]

@gageorgiev gageorgiev force-pushed the person/gageorgiev/python310 branch 5 times, most recently from 0da164a to 59e5f65 Compare November 19, 2021 09:55
@antoniivanov
Copy link
Collaborator

Don't forget to mark PR as draft (https://github.blog/2019-02-14-introducing-draft-pull-requests/)

Also, please split into 2 commits or 2 PRs for vdk-control-cli and vdk-core.

If you go with 2 commits remember to use to rebase option when merging .

@gageorgiev gageorgiev force-pushed the person/gageorgiev/python310 branch 2 times, most recently from 9aa2649 to e2f440f Compare November 19, 2021 10:56
@gageorgiev gageorgiev marked this pull request as draft November 19, 2021 11:01
@gageorgiev gageorgiev force-pushed the person/gageorgiev/python310 branch 3 times, most recently from 28e31d7 to 573316b Compare November 19, 2021 12:21
Signed-off-by: gageorgiev <[email protected]>
@gageorgiev gageorgiev marked this pull request as ready for review November 19, 2021 12:46
Signed-off-by: gageorgiev <[email protected]>
…tile-data-kit into person/gageorgiev/python310
@gageorgiev gageorgiev enabled auto-merge (squash) November 19, 2021 15:42
Copy link
Contributor

@YanaZhivkova YanaZhivkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gageorgiev gageorgiev merged commit 6245ce0 into main Nov 22, 2021
@gageorgiev gageorgiev deleted the person/gageorgiev/python310 branch November 22, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants