Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCH: requires excessive number of certificate files for tlsverify configuration #1930

Open
hickeng opened this issue Aug 14, 2018 · 1 comment · May be fixed by #2502
Open

DCH: requires excessive number of certificate files for tlsverify configuration #1930

hickeng opened this issue Aug 14, 2018 · 1 comment · May be fixed by #2502
Assignees
Labels
component/dinv The Docker-in-VIC container image impact/doc/kb Requires creation of or changes to an official knowledge base article kind/defect Behavior that is inconsistent with what's intended kind/feature New functionality you could include in marketing material product/ova Related to the OVA packaging of vSphere Integrated Containers severity/4-minor Low usability or functional impact. Often has an easy workaround. source/customer Reported by a customer, directly or via an intermediary

Comments

@hickeng
Copy link
Member

hickeng commented Aug 14, 2018

Story
As a DHC user I would like to be able to re-use the same certificates for the DCH as the VCH

Details
The documentation says (correctly) that to use existing certificates you must copy the following files into the DCH container before start:

  • /certs/docker.crt
  • /certs/docker.key
  • /certs/ca.pem

However the code requires that an additional three certificates be present which are not required and SHOULD NOT be present in a server (see

"/certs/ca-key.pem",
)

Workaround
The vch folder in the docker cp commands below is the VCH certificate directory that holds the generated certificates. The VCH is configured with tlsverify and the environment is configured with DOCKER_HOST, DOCKER_TLS_VERIFY, and DOCKER_CERT_PATH.

$ echo $DOCKER_HOST
192.168.78.127:2376
$ docker create --name build-slave -p 12376:2376 vmware/dch-photon:1.13 -tlsverify
$ docker cp vch/ca.pem build-slave:/certs/ca.crt
$ docker cp vch/server-key.pem build-slave:/certs/docker.key
$ docker cp vch/server-cert.pem build-slave:/certs/docker.crt
$
$ # work around the check for files that are not needed
$ touch vch/tmp
$ docker cp vch/tmp build-slave:/certs/ca-key.pem
$ docker cp vch/tmp build-slave:/certs/docker-client.key
$ docker cp vch/tmp build-slave:/certs/docker-client.crt
$
$ docker start build-slave
$ docker -H $(docker port build-slave 2376) --tlsverify info
....
@hickeng hickeng added kind/defect Behavior that is inconsistent with what's intended product/ova Related to the OVA packaging of vSphere Integrated Containers component/dinv The Docker-in-VIC container image source/customer Reported by a customer, directly or via an intermediary severity/4-minor Low usability or functional impact. Often has an easy workaround. labels Aug 14, 2018
@stuclem
Copy link
Contributor

stuclem commented Aug 17, 2018

@hickeng this fix will make the code match the doc in 1.4.3, but do we need to release note this in 1.4.0-1.4.2?

@zjs zjs added the impact/doc/kb Requires creation of or changes to an official knowledge base article label Aug 23, 2018
@zjs zjs removed the priority/p3 label Jan 29, 2019
@renmaosheng renmaosheng added the kind/feature New functionality you could include in marketing material label Mar 12, 2019
@nhinds nhinds linked a pull request Aug 10, 2019 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dinv The Docker-in-VIC container image impact/doc/kb Requires creation of or changes to an official knowledge base article kind/defect Behavior that is inconsistent with what's intended kind/feature New functionality you could include in marketing material product/ova Related to the OVA packaging of vSphere Integrated Containers severity/4-minor Low usability or functional impact. Often has an easy workaround. source/customer Reported by a customer, directly or via an intermediary
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants