Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dinv checking for unused certificate files #2502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nhinds
Copy link

@nhinds nhinds commented Aug 10, 2019

The ca-key.pem, docker-client.crt, and docker-client.key files are
generated when no certificates are present in /certs, but are not used
by docker at runtime and do not need to be checked at startup.

VIC Appliance Checklist:

  • Up to date with master branch
  • Added tests
    • There appear to be no tests for providing TLS certificates currently
  • Considered impact to upgrade
    • Providing the extra files will continue to work, and providing no files also works as documented. Only changes behaviour for people trying to provide ca.crt/docker.key/docker.crt on their own.
  • Tests passing
    • I could not find tests, but manually verified with /dinv, /dinv -tls, /dinv -tlsverify with and without certificates
  • Updated documentation
    • This change brings the behaviour closer to the documentation
  • Impact assessment checklist
    • I think the impact assessment checklist is only for the installer, so I have not completed one

Fixes #1930

The ca-key.pem, docker-client.crt, and docker-client.key files are
generated when no certificates are present in /certs, but are not used
by docker at runtime and do not need to be checked at startup.
@vmwclabot
Copy link
Member

@nhinds, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCH: requires excessive number of certificate files for tlsverify configuration
2 participants