REFACTOR-modin-project#2059: Introduce abstract parameter concept

Signed-off-by: Vasilij Litvinov <[email protected]>

modin/config/__init__.py

@@ -11,5 +11,5 @@
 # ANY KIND, either express or implied. See the License for the specific language
 # governing permissions and limitations under the License.
 
-from .pubsub import Parameter
-from .envvars import *
+from .pubsub import Parameter  # noqa: F401
+from .envvars import *  # noqa: F403, F401

modin/config/__main__.py

@@ -1,15 +1,11 @@
-from . import *
+from . import *  # noqa: F403, F401
+from .pubsub import Parameter
 
 
 def print_config_help():
     for objname in sorted(globals()):
         obj = globals()[objname]
-        if (
-            isinstance(obj, type)
-            and issubclass(obj, Parameter)
-            and obj is not EnvironmentVariable
-            and obj is not Parameter
-        ):
+        if isinstance(obj, type) and issubclass(obj, Parameter) and not obj.is_abstract:
             print(f"{obj.get_help()}\n\tCurrent value: {obj.get()}")
 
 

modin/config/envvars.py

@@ -19,7 +19,7 @@
 from .pubsub import Parameter, _TYPE_PARAMS
 
 
-class EnvironmentVariable(Parameter, type=str):
+class EnvironmentVariable(Parameter, type=str, abstract=True):
     """
     Base class for environment variables-based configuration
     """
@@ -201,9 +201,9 @@ def _check_vars():
     valid_names = {
         obj.varname
         for obj in globals().values()
-        if obj is not EnvironmentVariable
-        and isinstance(obj, type)
+        if isinstance(obj, type)
         and issubclass(obj, EnvironmentVariable)
+        and not obj.is_abstract
     }
     found_names = {name for name in os.environ.keys() if name.startswith("MODIN_")}
     unknown = found_names - valid_names

modin/config/pubsub.py

@@ -61,6 +61,7 @@ class Parameter(object):
     choices: typing.Sequence[str] = None
     type = str
     default = None
+    is_abstract = True
 
     @classmethod
     def _get_raw_from_config(cls) -> str:
@@ -79,9 +80,10 @@ def get_help(cls) -> str:
         """
         raise NotImplementedError()
 
-    def __init_subclass__(cls, type, **kw):
+    def __init_subclass__(cls, type, abstract=False, **kw):
         assert type in _TYPE_PARAMS, f"Unsupported variable type: {type}"
         cls.type = type
+        cls.is_abstract = abstract
         cls._value = _UNSET
         cls._subs = []
         cls._once = collections.defaultdict(list)