fix(movable): should skip ingore step if not specified

vnphanquang · Oct 3, 2022 · 53b9606 · 53b9606
1 parent aedc4d9
commit 53b9606
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/dirty-candles-shake.md b/.changeset/dirty-candles-shake.md
@@ -0,0 +1,5 @@
+---
+"@svelte-put/movable": patch
+---
+
+fix: skip ignore step if not provided
diff --git a/packages/actions/movable/src/movable.ts b/packages/actions/movable/src/movable.ts
@@ -217,9 +217,12 @@ export function movable(node: HTMLElement, parameters: MovableParameters = { ena
   };
 
   const onMouseDown = (event: MouseEvent) => {
-    const excludedNodes = Array.from(trigger.querySelectorAll(ignore.join(', ')));
-    if (excludedNodes.some((node) => node.isSameNode(event.target as HTMLElement))) {
-      return;
+    const ignoreSelector = ignore.join(',');
+    if (ignoreSelector) {
+      const excludedNodes = Array.from(trigger.querySelectorAll(ignore.join(', ')));
+      if (excludedNodes.some((node) => node.isSameNode(event.target as HTMLElement))) {
+        return;
+      }
     }
 
     const computedStyles = getComputedStyle(node);