Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anonymous envelope (zk) verification with test #262

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

arnaucube
Copy link
Contributor

@arnaucube arnaucube commented Sep 12, 2021

No description provided.

@arnaucube arnaucube marked this pull request as draft September 12, 2021 21:09
@arnaucube arnaucube force-pushed the feature/anonymous-envelope-verif branch 3 times, most recently from 3a1a894 to fd64c96 Compare September 13, 2021 15:02
@arnaucube arnaucube changed the title [WIP] Add anonymous envelope (zk) verification Add anonymous envelope (zk) verification with test Sep 13, 2021
@arnaucube arnaucube marked this pull request as ready for review September 13, 2021 15:09
@arnaucube arnaucube force-pushed the feature/anonymous-envelope-verif branch from fd64c96 to 1d144ca Compare September 13, 2021 15:13
Comment on lines +214 to +218
// TODO the next 12 lines of code are the same than a little
// further down. TODO: maybe move them before the 'switch', as
// is a logic that must be done even if
// process.EnvelopeType.Anonymous==true or not
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be done in a future PR.

@arnaucube arnaucube force-pushed the feature/anonymous-envelope-verif branch from 1d144ca to b3a6886 Compare September 13, 2021 15:15
vochain/transaction.go Outdated Show resolved Hide resolved
vochain/transaction.go Outdated Show resolved Hide resolved
@arnaucube arnaucube force-pushed the feature/anonymous-envelope-verif branch from b3a6886 to b899d27 Compare September 13, 2021 15:49
@arnaucube arnaucube force-pushed the feature/anonymous-envelope-verif branch from b899d27 to db17ec4 Compare September 13, 2021 15:56
Copy link
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, wait until this is merged #260 to merge this PR to resolve possible conflicts in chronological order :)

@arnaucube arnaucube force-pushed the feature/anonymous-envelope-verif branch from db17ec4 to 96fce9d Compare September 16, 2021 16:41
@arnaucube
Copy link
Contributor Author

Rebased to master branch, including the changes from #260 .

@arnaucube arnaucube merged commit 31d448d into master Sep 16, 2021
@arnaucube arnaucube deleted the feature/anonymous-envelope-verif branch September 16, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants