Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SDK #8

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Fix SDK #8

merged 3 commits into from
Apr 16, 2024
+108 −39

Conversation

macwilk
Copy link
Contributor

@macwilk macwilk commented Apr 16, 2024

No description provided.

@macwilk macwilk requested a review from ajar98 April 16, 2024 17:36
ajar98
ajar98 requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@ajar98 ajar98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add external_action_params.py and external_action_update_params.py to .fernignore - otherwise these changes will be overwritten by the next release

@macwilk macwilk requested a review from ajar98 April 16, 2024 18:25
ajar98
ajar98 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@ajar98 ajar98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome - you'll have to re-release the SDK now from vocode-api-generator

@macwilk macwilk merged commit ce3d953 into main Apr 16, 2024
3 checks passed
@macwilk macwilk deleted the mac/manual-documentation-fix branch April 16, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajar98 ajar98 ajar98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macwilk @ajar98 @srhinos