Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update timestamp #60

Merged
merged 2 commits into from
May 28, 2020
Merged

fix: update timestamp #60

merged 2 commits into from
May 28, 2020

Conversation

leartgjoni-voiceflow
Copy link
Contributor

No description provided.

@leartgjoni-voiceflow leartgjoni-voiceflow added the in progress In progress, should not be merged label May 28, 2020
@effervescentia
Copy link
Contributor

Codecov Report

❗ No coverage uploaded for pull request base (master@8c5b466). Click here to learn what that means.
The diff coverage is n/a.

@leartgjoni-voiceflow leartgjoni-voiceflow added ready for review and removed in progress In progress, should not be merged labels May 28, 2020
zhihil
zhihil reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@zhihil zhihil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ready for merging.

This is working on the prototype tool. Unit tests are all there and are comprehensive.

Leart has done the testing on ADC, screencap below:

https://voiceflowhq.slack.com/files/ULJS98MUM/F0148R36NJJ/screen_shot_2020-05-28_at_3.54.09_pm.png?origin_team=TAC8TMFFF&origin_channel=C012GP6QFF1

zhihil
zhihil approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@zhihil zhihil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged

@leartgjoni-voiceflow leartgjoni-voiceflow merged commit e63819b into master May 28, 2020
@voiceflow-dev
Copy link

🎉 This PR is included in version 1.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@frankgu968 frankgu968 deleted the leart/timestamp-test-tool/CORE-3125 branch June 5, 2020 15:43
DecathectZero pushed a commit that referenced this pull request Sep 8, 2020
@leartgjoni-voiceflow @DecathectZero
fix: update timestamp (#60)
2d1bf9f 
* fix: update timestamp

* test: new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhihil zhihil zhihil approved these changes

Assignees
No one assigned
Labels
ready for review released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leartgjoni-voiceflow @effervescentia @voiceflow-dev @zhihil