-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page for NFS #382
Add page for NFS #382
Conversation
Do you think you could add the server section as well? I can help with verification and ask for verification from other knowledgeable members. |
@llimllib: Thanks for your contribution! As per #327, my preference would be to have this information as part of a more general page for "Network filesystems", which could also include content about Samba. (This PR doesn't need to include that content, however; it can be added later.) Please don't mix unrelated changes in a single PR; the change to the README to mention |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can find the style guide here: https://docs.voidlinux.org/contributing/void-docs/style-guide.html
To be merged, the PR should also be a single commit, since you're adding a single file. To fix the indentation, you can run vmdfmt
locally on your device.
I think I have responded to all feedback, thanks and it should be ready for re-review. (I'm used to squashing merges when the PR is complete, I apologize for having pushed multiple commits) |
I added the information from void-linux/void-runit#16 that allows a computer to reboot once it has a share mounted |
More or less totally rewritten since I found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your continued work on this! Once the requested changes are addressed, we'll be a lot closer to being able to merge.
I believe I made all requested changes. (Is there any chance you would consider squashing PRs at merge time in this repo instead of requiring a single commit? That would make it easier for us to collaborate, because you could just make these changes and push them instead of us playing telephone, with me editing a section I don't know anything about?) |
@llimllib: Thanks! But, sorry, i'm not sure i follow. If you use the |
no worries! I know how to squash commits - I'm just wondering if it would be easier to collaborate by not squashing until it's time to merge |
I believe I have responded to all of your comments, and that is the limit of the amount of work I'm willing to do on this. Thank you for hopefully landing the doc page, and for the help on irc. |
@llimllib thank you for the initial work, and for letting us know! |
This PR adds an "NFS" section to the documentation website.
I found the wiki page helpful in getting me up and running with void, so I wanted to migrate it to the new documentation site.
I only migrated the client section because I do not trust myself to migrate the server section without messing up some detail; I have verified the commands in the client section.
I also added
mdbook-linkcheck
as a build dependency to the README