-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config/media/pipewire: rewrite for clarity #772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classabbyamp
force-pushed
the
pw-rewrite
branch
from
September 5, 2023 05:20
ceb86a6
to
3018331
Compare
classabbyamp
force-pushed
the
pw-rewrite
branch
from
October 27, 2023 15:16
3018331
to
20e2f4f
Compare
for xinitrc "starting arbitrary programs". starting pipewire in the xinitrc isn't practical unless using a user dbus service.
classabbyamp
force-pushed
the
pw-rewrite
branch
from
October 27, 2023 15:22
20e2f4f
to
e65d237
Compare
tested in a freshly-installed VM to ensure things work and collect common error messages. |
lemmi
reviewed
Oct 27, 2023
ahesford
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
lemmi
reviewed
Oct 27, 2023
classabbyamp
force-pushed
the
pw-rewrite
branch
3 times, most recently
from
October 27, 2023 15:55
4cf9fa2
to
2b74fb3
Compare
paper42
reviewed
Oct 27, 2023
classabbyamp
force-pushed
the
pw-rewrite
branch
from
October 27, 2023 17:46
2b74fb3
to
2cf0d67
Compare
it seems a lot of people have trouble with this guide, and there's a lot of forks/options at each step. This rewrites the guide to streamline it into "basic setup" (wireplumber and optionally pw-pulse) and "optional setup" (everything else). Also, this only documents the conf.d method as it's the most straightforward (IMO) and provides consistent results (wrt launch order and ensuring things are launched). I don't think we need to document every single option and overwhelm users, this guide is already very verbose.
classabbyamp
force-pushed
the
pw-rewrite
branch
from
October 27, 2023 20:25
2cf0d67
to
eeb5ef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems a lot of people have trouble with this guide, and there's a lot of forks/options at each step. This rewrites the guide to streamline it into "basic setup" (wireplumber and optionally pw-pulse) and "optional setup" (everything else).
Also, this only documents the conf.d method as it's the most straightforward (IMO) and provides consistent results (wrt launch order and ensuring things are launched). I don't think we need to document every single option and overwhelm users, this guide is already very verbose.
closes #672
Still TODO: