-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Llvm13 #36229
Llvm13 #36229
Conversation
Thanks. Can you fix the trivial linting?
And perhaps then let it run on CI? @q66 Can you review this? |
Will do that, I will rebuild all packages locally. Could you check that all the packages that I am rebuilding need to be rebuild ? @dkwo / @ifreund could you try to compile llvm13 on your pc ? My dual core is failing and I am not sure if its because of my low hardware |
xrevshlib libllvm{12,13} also includes gtkd, onedrive: perhaps rebuild these as well?
I'm building llvm13 now, will report back.
|
on x86_64, it now fails with
|
Does |
I'm now trying to build it after downgrading docutils to 0.17 |
That seems to be the issue Sphinx upstream doesn't support docutils-0.18.X |
Ok, llvm13 builds fine on x86_64 after downgrading docutils:
…-version=0.18.1
-revision=1
+version=0.17.1
+revision=3
|
also zig builds, but river:
=> river-0.1.3_1: installing host dependencies: pkg-config-0.29.2_3 wayland-devel-1.20.0_1 scdoc-1.11.2_1 git-2.35.1_1 zig-0.9.1_1 ...
=> river-0.1.3_1: installing target dependencies: wlroots-devel-0.15.1_1 ...
=> river-0.1.3_1: removing autodeps, please wait...
=> ERROR: river-0.1.3_1: failed to install target dependencies! (error 8)
mesa-opencl-21.3.7_1: broken, unresolvable shlib `libclang-cpp.so.12'
Transaction aborted due to unresolved shlibs.
=> ERROR: Please see above for the real error, exiting...
|
Forget about river, it also builds after rebuilding mesa. |
Thanks. Indeed, after rebasing, llvm13 builds fine here. |
On the other hand, when building
|
This pr for llvm13 has one patch less then our llvm12, still at 20 something. |
That's interesting, actually I picked on the work made previously, and
worked from there. The only thing I changed on the template was the
bump to .1 release.
Now, to your question. I am not aware of what patches are really
needed, for cross compiling for all archs that void support, someone
more knowledge on the distro might help.
(I am going to join the IRC channel #xbps, ping me there, so we can get
this issue solved, I am "motorto" there).
…On qua, mar 23 2022 at 08:00:51 -0700, dkwo ***@***.***> wrote:
This pr for llvm13 has one patch less then our llvm12, still at 20
something.
(For comparison Alpine has 3 patches.)
Are all our patches needed for cross? Which are actually necessary?
—
Reply to this email directly, view it on GitHub
<#36229 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRTQPJONLNKQKVRUBLQJCDVBMW2HANCNFSM5REOSBUA>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
How come LLVM13 for Void Linux is taking this long to get added? is it not receiving the attention it needs from the primary maintainers? edit:
|
@wael444 not sure how your comment is helpful at all. This community is based purely on volunteers. If something takes too long for you, feel free to give a helpful hand. |
also: i am merely just someone wanting to use |
llvm14 is out now, so we should probably jump straight to that |
After adding this patch, I was able to build |
One downside to jumping straight to 14 is that it will probably be a few months until there is a zig release compatible with llvm 14. Furthermore, I believe patching zig ourselves would very non-trivial this time due to major changes in llvm's API relating to making all pointers in the IR opaque. |
(Going to do this)
@wael444, if you want to help fell free to build all changed packages in this pr and report back please, don't know if you are using any different arch/libc library. I moved way from void because I needed the llvm13, I am still working in this using a vm (I intend to come back once this is merged).
@dkwo and I build it successful on x86_64 glibc, 6 days ago. Are you using any different arch ? |
No.
|
@motorto As I said, with that patch it builds fine on I also agree we should do llvm13 first, and hofully soon, as it is close to working condition. |
|
Zap and then pkg -f llvm13, not river..
|
didn't push yet because I am having the same issue as @wael444 |
This has been deprecated by upstream which recommends using dumb_runtime_dir (already packaged for void) instead. Removing now since rundird 0.2.0 is not compatible with zig 0.9 and there won't be any new rundird releases.
Rebased and fixed the conflicts |
there is already a PR for llvm 14 open, work on that instead |
|
What about programs (like zig) that still require llvm 13? It looks like the work has already been done here, no need to throw it away. |
On llvm14 pr he kept the llvm12 just for that purpose ... Totally forgot about that package, should we keep this open or discard llvm13 in favor of llvm14,@q66 |
there is no rule saying we can't keep an older llvm runtime library for things that don't support the newer one (i.e. 12 for zig, 14 for most other things) it's been done before |
I will try to help on the llvm14 package then. |
fwiw it's a bit tricky for zig as far as i understand it because it also needs libclang, but we can probably have a versioned libclang package just like we have a versioned libllvm package, and then there will be no problem (the |
Zig links against all 3 of llvm, clang, and lld. I left a comment on the LLVM 14 PR and I believe the author already split off llvm/clang/lld 12 packages for that purpose. |
it's the same story for anything else, runtime libraries need to be split into packages that have version in the name in a way that doesn't conflict with the rest (everything else can conflict) |
@ifreund Assuming we're going to skip llvm13, is there a way to patch our current river so that xwayland is not broken, without relying on llvm13? i.e. would it work to add the patch riverwm/river@e16eabd ? |
There is, I patched, packaged and published River with that XWayland patch at https://void.gsr.dev. Here is the source, in case you want to build it yourself. |
Thank you.
For the moment, river built with llvm13 still works,
but I will look at your source in case it stops with
future llvm updates.
|
I will try to do that today. I will ping you when finished.
…On Sat, May 21 2022 at 09:11:47 AM -0700, Érico Nogueira Rolim ***@***.***> wrote:
If you could try rebasing and fixing conflicts as well, that'd be
awesome.
—
Reply to this email directly, view it on GitHub
<#36229 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRTQPJVYDYUK4P7KZN6QE3VLEDMHANCNFSM5REOSBUA>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This adds LLVM 13 and updates from LLVM 12.
Work-in-progress
The following packages were removed:
The following packages were updated or patched:
Rebuilt packages:
(rebuilt based on output of:
xrevshlib libllvm{12,13}
)Updated Templates:
(I am probably missing some packages)
Thanks @DBLouis for your hard work!
[ci skip]
I nuked the #35895