-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/faq #63
Open
NyaGarcia
wants to merge
16
commits into
master
Choose a base branch
from
feat/faq
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/faq #63
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1575621
feat(app): add app-routing.module
NyaGarcia 05fb2fb
feat(pages): add faq page
NyaGarcia 4417450
refactor(app.component): remove communities logic
NyaGarcia 2e3bba5
feat(app.module): import AppRoutingModule
NyaGarcia f50d254
feat(main.component): add communities logic
NyaGarcia 370214d
feat(pages.module): import FaqModule
NyaGarcia 00efe59
feat(shared.module): import RouterModule
NyaGarcia 1f5f879
feat(header.component): add styles and routing
NyaGarcia 7f8506d
refactor(main.component): remove console.log
NyaGarcia 32a3833
refactor(faq.module): remove unused modules
NyaGarcia 65e0b60
fix(main.component): adapt code to consider that communitie$ is an ob…
NyaGarcia f4afebb
refactor(community.service): add shareReplay(1) to avoid multiple req…
NyaGarcia 3adca70
fix(community.service): change getter to communitie$ property
NyaGarcia 0704bc4
feat(main.component): access community service communitie$ property
NyaGarcia 389d7dc
Merge branch 'master' into feat/faq
Caballerog 066f28b
feat(faq): Lazy-loading
Caballerog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { NgModule } from '@angular/core'; | ||
import { Routes, RouterModule } from '@angular/router'; | ||
import { FaqComponent } from '@pages/faq/faq.component'; | ||
import { MainComponent } from '@pages/main/main.component'; | ||
|
||
const routes: Routes = [ | ||
{ path: '', component: MainComponent }, | ||
{ path: 'faq', component: FaqComponent }, | ||
{ | ||
path: '**', | ||
redirectTo: '', | ||
}, | ||
]; | ||
|
||
@NgModule({ | ||
imports: [RouterModule.forRoot(routes)], | ||
exports: [RouterModule], | ||
}) | ||
export class AppRoutingModule {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
h6 { | ||
color: #c10707; | ||
font-size: 20px; | ||
} | ||
|
||
a { | ||
color: #c10707; | ||
} | ||
|
||
.text-container { | ||
margin-left: 15%; | ||
margin-right: 15%; | ||
color: #333; | ||
} | ||
|
||
.text-content { | ||
font-weight: 400; | ||
line-height: 1.5; | ||
font-size: 16px; | ||
} | ||
|
||
.question { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should make the design responsive |
||
margin: 20px; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
<div class="text-container"> | ||
<div class="text-content"> | ||
<div class="question"> | ||
<h6>What is Angular-Communities?</h6> | ||
<p> | ||
Angular-communities in an initiative born in Málaga, Spain. It started as a small | ||
open-source project built by four Angular devs from Málaga (see about us for more info) who | ||
aimed to create a space where every single Angular community out there could be found and | ||
located on the world map. This way, the visibility of all the Angular communities around the | ||
world is increased, which is always a good thing! As more and more community members started | ||
to show interest in Angular-Communities, our small project began to grow. Our goal now is to | ||
create a space where all information regarding Angular can be found: communities, | ||
conferences, events... | ||
</p> | ||
</div> | ||
<div class="question"> | ||
<h6>I host an Angular community, can I add it to Angular-Communities?</h6> | ||
<p>Of course! We're looking forwards to adding your community.</p> | ||
</div> | ||
<div class="question"> | ||
<h6>Can Angular conferences/events like ngSpain, ngConf etc. be added too?</h6> | ||
<p> | ||
We're working on also adding all the Angular events! Would you like to help us out? You can | ||
find more information | ||
<a target="_blank" href="https://github.com/voidcosmos/angular-communities/issues/42" | ||
>here</a | ||
>. | ||
</p> | ||
</div> | ||
<div class="question"> | ||
<h6>How do I add my community to Angular-Communities?</h6> | ||
<p> | ||
All you need to do is open a PR, filling in the required fields with the information about | ||
your community. We'll review it, and if all is well, your community will be added! For more | ||
info, see | ||
<a target="_blank" href="https://github.com/voidcosmos/angular-communities" | ||
>the Angular-Communities README.</a | ||
> | ||
</p> | ||
</div> | ||
<div class="question"> | ||
<h6>Can I participate in the Angular-Communities project?</h6> | ||
<p> | ||
Of course you can! Any help at all is very welcome. See the following question for | ||
information on how to contribute. | ||
</p> | ||
</div> | ||
<div class="question"> | ||
<h6>How can I contribute to the Angular-Communities project?</h6> | ||
<p> | ||
You can find all the information related to contributing | ||
<a | ||
target="_blank" | ||
href="https://github.com/voidcosmos/angular-communities/blob/master/.github/CONTRIBUTING.md" | ||
>here</a | ||
>. | ||
</p> | ||
</div> | ||
</div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { Component } from "@angular/core"; | ||
|
||
@Component({ | ||
selector: "app-faq", | ||
templateUrl: "./faq.component.html", | ||
styleUrls: ["./faq.component.css"] | ||
}) | ||
export class FaqComponent {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { NgModule } from '@angular/core'; | ||
import { CommonModule } from '@angular/common'; | ||
import { SharedModule } from '@shared/shared.module'; | ||
import { FlexLayoutModule } from '@angular/flex-layout'; | ||
import { FaqComponent } from './faq.component'; | ||
|
||
const COMPONENTS = [FaqComponent]; | ||
|
||
@NgModule({ | ||
declarations: [COMPONENTS], | ||
imports: [CommonModule, SharedModule, FlexLayoutModule], | ||
exports: [COMPONENTS], | ||
}) | ||
export class FaqModule {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,9 +6,10 @@ | |
alt="Angular communities logo" | ||
src="assets/images/angular-communities-logo_md.png" | ||
/> | ||
<span>ANGULAR COMMUNITIES</span> | ||
<a routerLink="">ANGULAR COMMUNITIES</a> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👏👏 |
||
</div> | ||
<div> | ||
<a class="menu" routerLink="/faq">FAQ</a> | ||
<a | ||
href="https://www.github.com/voidcosmos/angular-communities" | ||
target="_blank" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FAQ module can be built in a lazy way