Fix types/node version issue

voila-dashboards · Mar 31, 2023 · ece8fc4 · ece8fc4
1 parent 565aa71
commit ece8fc4
Show file tree

Hide file tree

Showing 4 changed files with 472 additions and 469 deletions.
diff --git a/package.json b/package.json
@@ -22,8 +22,8 @@
     "build:prod": "lerna run build:prod",
     "build:test": "lerna run build:test",
     "clean": "lerna run clean",
-    "eslint": "eslint . --ext .ts,.tsx,.js,.jsx --fix",
-    "eslint:check": "eslint . --ext .ts,.tsx,.js,.jsx",
+    "eslint": "eslint . --ext .ts,.tsx --fix",
+    "eslint:check": "eslint . --ext .ts,.tsx",
     "install": "lerna bootstrap",
     "prettier": "prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
     "prettier:check": "prettier --list-different \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",

diff --git a/packages/voila/package.json b/packages/voila/package.json
@@ -46,7 +46,7 @@
     "@babel/core": "^7.2.2",
     "@babel/preset-env": "^7.3.1",
     "@jupyterlab/builder": "^3.0.0",
-    "@types/node": "^18.8.3",
+    "@types/node": "~18.8.3",
     "babel-loader": "^8.0.5",
     "css-loader": "^6.7.2",
     "file-loader": "^6.2.0",

diff --git a/voila/handler.py b/voila/handler.py
@@ -86,7 +86,6 @@ async def get_generator(self, path=None):
             return
 
         cwd = os.path.dirname(notebook_path)
-        print("#########", cwd)
         # Adding request uri to kernel env
         request_info = {}
         request_info[ENV_VARIABLE.SCRIPT_NAME] = self.request.path
@@ -258,7 +257,6 @@ async def put_html():
 
     @tornado.web.authenticated
     async def get(self, path=None):
-        print("OPATH", path)
         gen = self.get_generator(path=path)
         async for html in gen:
             self.write(html)