-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support progressive rendering #1489
Conversation
04d1ecd
to
1fc480b
Compare
ui-tests/tests/voila.test.ts-snapshots/voila-tree-classic-linux.png
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused about the tree snapshots changes, do you why it shows these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah me too. Something may have changed in the file browser package? I will check tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the previous snapshot was supposed to be the JupyterLab file browser, since it's the default now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, both the old and new snapshots are using JupyterLab file browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a couple of commits to disable the progressive rendering feature when jupyter-server 1 is installed.
Apart from the changes in the ui-tests that I'm confused about, that looks good to me!
Failed tests in python 3.8 are not related. Python 3.8 is end-of-life already https://devguide.python.org/versions/#python-release-cycle. Let's remove 3.8 and add 3.12 to the matrix in a follow-up PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fix #634
User-facing changes
voila3.mp4
--progressive_rendering
to activate the progressive rendering mode--progressive_rendering
and--preheat_kernel
are incompatible.Code changes
In progressive rendering mode:
/voila/execution
to receive execution request from the frontend and return the cell outputs.nbconvert
does not execute notebooks anymore. The frontend will render the dashboard immediately, then it sends an execution request to the above Websocket endpoint.OutputArea
widgets are created at the corresponding cell to render the outputs.execute_input
messages are filteredBackwards-incompatible changes
N/A