(Temporary) caching cdn handler until we sort out bundling #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue to solve
For loading js modules, we have to choose a system, either the notebook extension method or the jupyter lab bundling. This new loader (frontend) will be a temporary solution that will 'just work' until we find the proper way to do this. It will try to fetch from
<server>/voila/require/module@semver
, which at the server willBut only for modules in a whitelist (security concern)
Issues:
It will not respect semver, so will never fetch a patched version once it cached a version.
Where cache?
It first tries
{prefix}/share/jupyter/voila_cache/{module}/{semver}
, and on failure will use the user directory.Note
This is based on #2, so that first needs to be merged, and this rebased.