Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix README broken URL #3718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: fix README broken URL #3718

wants to merge 1 commit into from

Conversation

jasondrogba
Copy link

the url on README can not access, replace it with correct one

@volcano-sh-bot
Copy link
Contributor

Welcome @jasondrogba!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2024
@jasondrogba
Copy link
Author

hi, can you review this PR ~ @k82cn
/assign @k82cn

@jasondrogba
fix README broken URL
9f96b27 
Signed-off-by: jasondrogba <[email protected]>
hwdef
hwdef reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@volcano-sh-bot volcano-sh-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Sep 12, 2024
@jasondrogba
Copy link
Author

@hwdef @k82cn hi~ why the workflow is still pending😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

At least 1 approving review is required to merge this pull request.

Assignees

@hwdef hwdef

@k82cn k82cn

Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasondrogba @volcano-sh-bot @hwdef @k82cn