Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Blog Posts: 《Volcano 源码分析》（一）&（二） #318

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Blog Posts: 《Volcano 源码分析》（一）&（二） #318

wants to merge 3 commits into from

Conversation

daniel-hutao
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

/kind documentation

  • What this PR does / why we need it:

Two blogs about Volcano

  • Which issue(s) this PR fixes:

N/A

@volcano-sh-bot
Copy link
Collaborator

Welcome @daniel-hutao!

It looks like this is your first PR to volcano-sh/website 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. labels Jan 4, 2024
@volcano-sh-bot volcano-sh-bot added kind/feature Categorizes issue or PR as related to a new feature. kind/design Categorizes issue or PR as related to design. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 4, 2024
@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2024
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Arhell
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lowang-bh
Copy link
Member

/hold

@volcano-sh-bot volcano-sh-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2024
@lowang-bh
Copy link
Member

why put your self's blog id here?

@hwdef
Copy link
Member

hwdef commented Jan 8, 2024

I don't think it's appropriate either.

@daniel-hutao
Copy link
Author

why put your self's blog id here?

What's the id? @lowang-bh

@kevin-wangzefeng
Copy link
Member

why put your self's blog id here?

What's the id? @lowang-bh

I think you mean this part? @lowang-bh

https://github.com/volcano-sh/website/pull/318/files#diff-8b7ccf455e97b1cd5aa84b772fa0623e5be8322fd8ddde1ce217bb19ae362fb9R29-R31

kevin-wangzefeng
kevin-wangzefeng reviewed Jan 8, 2024
View reviewed changes
content/zh/blog/source-code-1.md Outdated Show resolved Hide resolved
content/zh/blog/source-code-1.md Outdated Show resolved Hide resolved
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@volcano-sh-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

daniel-hutao and others added 3 commits January 8, 2024 17:09
@daniel-hutao
add two new blogs about volcano source code
adcd19f 
Signed-off-by: Daniel Hu <[email protected]>
@daniel-hutao @kevin-wangzefeng
Update content/zh/blog/source-code-1.md
0a1cafd 
Co-authored-by: Kevin Wang <[email protected]>
Signed-off-by: Daniel Hu <[email protected]>
@daniel-hutao @kevin-wangzefeng
Update content/zh/blog/source-code-1.md
fd3460e 
Co-authored-by: Kevin Wang <[email protected]>
Signed-off-by: Daniel Hu <[email protected]>
@hwdef
Copy link
Member

hwdef commented Jan 8, 2024

Source code may change frequently, and this kind of article on source code interpretation is not suitable for official documentation website. In fact, many open source projects do not do so.

hwdef
hwdef reviewed Jan 8, 2024
View reviewed changes
static/img/source-code-1-banner.jpeg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two banner pictures are meaningless.

@kevin-wangzefeng
Copy link
Member

kevin-wangzefeng commented Jan 8, 2024 •
edited
Loading

Source code may change frequently, and this kind of article on source code interpretation is not suitable for official documentation website. In fact, many open source projects do not do so.

Thanks for raising this concern. As the articles are submitted as blog posts, not document, I think it's fine.
But it could have been better if mentioning the code version, e.g. which release tag code is used for the article.

lowang-bh
lowang-bh reviewed Jan 9, 2024
View reviewed changes
content/zh/blog/source-code-2.md

{{<figure library="1" src="source-code-2-banner.jpeg">}}

> - 本文首发于微信公众号“**胡说云原生**”；
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

content/zh/blog/source-code-2.md
draft = false # Is this a draft? true/false
toc = true # Show table of contents? true/false
type = "posts" # Do not modify.
authors = ["Daniel Hu - 胡说云原生"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowang-bh lowang-bh lowang-bh left review comments

@hwdef hwdef hwdef left review comments

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

@Arhell Arhell Arhell approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@Arhell Arhell

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@daniel-hutao @volcano-sh-bot @lowang-bh @hwdef @kevin-wangzefeng @Arhell