Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox type with Filtering option Added (ComboBox filtered by textInput) #2037

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

birddevelper
Copy link

It was difficult to find items in big lists. So a filtering input box below the ComboBox (Select tag) can simply solve this problem.

type : 'filtered'

It was difficult to find items in big lists. So a filtering input box below the ComboBox (Select tag) can simply solve this problem.

type : 'filtered'
@hikalkan
Copy link
Member

Thank you for your contribution.

  • Can you send a screenshot (or add to Plunker) se we can see how it works?
  • Instead of adding a new type, can you just add a new option to the field definition, like filtering: true. Because it's type is not changing, it's still combobox, but adding a new feature.

@hikalkan hikalkan added this to the v2.5.0 milestone Mar 29, 2017
@birddevelper
Copy link
Author

birddevelper commented Mar 29, 2017

screenshot :
screenshot

actually I've just moved the input box above the comboBox, it seems better.

honestly adding it as option needs more times and reading your code, I have no idea how to do that. :)

what is your opinion about changing the 'filtered' type to 'filteredList'?

@hikalkan
Copy link
Member

You have added a new filtering textbox to filter a combobox? I think it does not seems good.
I was expecting something like https://silviomoreto.github.io/bootstrap-select/examples/#live-search :)

@birddevelper
Copy link
Author

birddevelper commented Mar 29, 2017

Thanks for your motivating :))

anyway, finding an item in large lists is too difficult, and this inputbox solves this problem.
I think at the first step we add this input to facilitate finding items, and at the second step we enhance its appearance as you expect. :)

however I try my best to find a way to design something near what you expected.

@hikalkan hikalkan removed this from the v2.5.0 milestone Mar 29, 2017
@hikalkan
Copy link
Member

Maybe it's better to use bootstrap-select or a similar library instead of creating a solution ourselves. jtable allows you to override HTML for inputs (see http://jtable.org/ApiReference/FieldOptions#fopt-input). So, we can define input option and use bootstrap-select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants