Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uninstall command's help text with examples of what can actually be uninstalled #1628

Merged
merged 4 commits into from
Jan 1, 2024

Conversation

MrChocolatine
Copy link
Contributor

@MrChocolatine MrChocolatine commented Dec 26, 2023

Following this comment from @chriskrycho:
#1563 (comment)

Resolves #1563

@MrChocolatine MrChocolatine changed the title Remove node and npm from uninstall command's help text Update uninstall command's help text with examples of what can actually be uninstalled Dec 26, 2023
Copy link
Contributor

@charlespierce charlespierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking this on!

At the time of writing this, uninstalling this tool is not supported:

```
➜ volta uninstall node
error: Uninstalling node is not supported yet.
```

Resolves volta-cli#1563
At the time of writing this, uninstalling this tool is not supported:

```
➜ volta uninstall npm
error: Uninstalling npm is not supported yet.
```

Resolves volta-cli#1563
At the time of writing this, uninstalling this tool is not supported:

```
➜ volta uninstall yarn
error: Uninstalling yarn is not supported yet.
```
With examples of what can actually be uninstalled.
@MrChocolatine
Copy link
Contributor Author

MrChocolatine commented Dec 31, 2023

Rebased and green again @charlespierce .

@chriskrycho chriskrycho merged commit fc8ff66 into volta-cli:main Jan 1, 2024
10 of 11 checks passed
@chriskrycho
Copy link
Contributor

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help text for volta uninstall --help incorrectly states node versions can be uninstalled
3 participants