Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code signing and update installer icon #1650

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

charlespierce
Copy link
Contributor

@charlespierce charlespierce commented Jan 16, 2024

Info

  • It looks like our Installer already works properly with Winget - Several versions are already set up.
  • However, there are a few pieces that we need to clean up:
    • The Installed app icon is the old Notion logo, not the Volta logo
    • The CI for releasing the build will not use code signing any more, given the hurdles / expense of code signing in CI.

Changes

  • Updated the .ico file that's included with the Windows installer to properly use the Volta logo.
  • Removed the now-expired code signing certificate from the CI build.

Testing

  • We will likely need to do some testing and set up automated releasing of new versions once a Release is published. However, since Volta 1.1.1 is already in Winget, we will need to wait until 2.0.0 to test and verify that process.

@charlespierce charlespierce changed the title [DO NOT MERGE] Remove code signing and update installer icon Remove code signing and update installer icon Jan 16, 2024
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My basic take: Oh, we can just simplify our process a whole bunch, neat!

@chriskrycho chriskrycho merged commit eacff22 into volta-cli:main Jan 17, 2024
11 checks passed
@charlespierce charlespierce deleted the winget_installer branch February 16, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants