refactor(subgraphs/exchange): fix build:fuse execution errors #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegofigs
commented
Apr 11, 2022
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| "deploy:avax": "graph deploy --node https://api.thegraph.com/deploy/ --ipfs https://api.thegraph.com/ipfs/ traderjoe-xyz/exchange exchange.avax.yaml", | |||
| "deploy:rinkeby": "graph deploy --node https://api.thegraph.com/deploy/ --ipfs https://api.thegraph.com/ipfs/ traderjoe-xyz/exchange-rinkeby-ii exchange.rinkeby.yaml", | |||
| "deploy:fuse": "graph deploy --node https://api.thegraph.com/deploy/ --ipfs https://api.thegraph.com/ipfs/ voltfinance/voltage-exchange exchange.fuse.yaml", | |||
| "deploy:fuse": "graph deploy --access-token $GRAPH_TOKEN --node https://api.thegraph.com/deploy/ --ipfs https://api.thegraph.com/ipfs/ diegofigs/voltfinance-exchange exchange.fuse.yaml", | |||
There was a problem hiding this comment.
REMINDER: this should be changed back before merge
| @@ -4,7 +4,7 @@ import { | |||
| BIG_DECIMAL_ZERO, | |||
| FACTORY_ADDRESS, | |||
| WHITELIST, | |||
| JOE_USDT_PAIR_ADDRESS, | |||
| VOLT_FUSD_PAIR_ADDRESS, | |||
There was a problem hiding this comment.
opted on using this pair since its the most liquid, regardless I think this reference is not used
| @@ -30,43 +30,43 @@ export function getJoePrice(block: ethereum.Block = null): BigDecimal { | |||
| } | |||
|
|
|||
| /* | |||
| * JOE price is the weighted average of JOE/AVAX * AVAX and JOE/USDT. | |||
| * VOLT price is the weighted average of VOLT/WFUSE * WFUSE and VOLT/USDC. | |||
| * | |||
| */ | |||
| export function getWavgJoePrice(block: ethereum.Block = null): BigDecimal { | |||
There was a problem hiding this comment.
Function was changed because build:fuse command failed reading a reference here; think this method is not called regardless.
diegofigs
changed the title
|
@diegofigs i think we can also try to finish this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.