Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend alarm-clock module : weekday selection #1640

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SimonMellerin
Copy link

@SimonMellerin SimonMellerin commented Nov 2, 2018

Hi,
I told you about this PR in June, well I was quite busy.. I've finally find some time to do it..

I've add some options to the alarm clock feature.
The idea here is to be able to choose for which weekdays alarm has to be enable.

I've also made a PR for Volumio-UI : volumio/Volumio2-UI#665

This is my first contribution, I tried to respect your code style, be nice :)

@SimonMellerin
Copy link
Author

Can we have some news with this one ? :)

@xipmix
Copy link
Contributor

xipmix commented Nov 21, 2019

You have 'TRANSALTE' instead of 'TRANSLATE' in the UIConfig.json.

it looks like the alarm defaults to being on every day, the user must select which days they don't want - is that correct?

@SimonMellerin
Copy link
Author

it looks like the alarm defaults to being on every day, the user must select which days they don't want - is that correct?

yep

@SimonMellerin
Copy link
Author

sorry you answered a long time ago, I've never took time to answer..

I also rebase on master and fix that 'TRANSALTE' issue

@relft
Copy link

relft commented Jan 16, 2021

hi,
any news about this feature?
Thanks

adamcohenrose pushed a commit to adamcohenrose/Volumio2 that referenced this pull request Feb 14, 2021
weekday config courtesy of SimonMellerin
volumio#1640
adamcohenrose pushed a commit to adamcohenrose/Volumio2 that referenced this pull request Feb 14, 2021
weekday config courtesy of SimonMellerin
volumio#1640
@moi90
Copy link

moi90 commented Jan 21, 2023

Was this ever merged? What is the earliest release to contain this improvement?

@SimonMellerin
Copy link
Author

no it was never merged :/

@moi90
Copy link

moi90 commented Jan 23, 2023

Has Volumio2 reached its end of life? If yes, is there maybe a way to port this plugin to Volumio3?

@SimonMellerin
Copy link
Author

I'm not a Volumio user anymore so : I don't know current version of volumio and I don't think i will port this to Volumio3 😬

Feel free to do what you want with this PR 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants