Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for playlist files in MPD plugin #1722 #1723

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SteveTalbot
Copy link
Contributor

This change to the MPD music service plugin enables Volumio to handle any playlist file format supported by MPD.

This is the fix for issue #1722. Tested and working with M3U playlists on Volumio for Raspberry Pi.

@volumio
Copy link
Owner

volumio commented Feb 26, 2019

Thanks Steve, for both PRs.
This one will take a while to test for regressions, but it is indeed a very useful PR. Will give it a spin this week

@cwh42
Copy link

cwh42 commented Aug 26, 2019

Any news here?

@BreadPitch
Copy link

Any update? Really need this, as this is the feature that decides we use Volumio for playback or not.

@azathoth123
Copy link

Agreed. Thing is, it's already done, just needs testing and merge.
I've given up on using the built in web UI for playback. Been using 'mpdroid' app, so much easier.

@BreadPitch
Copy link

MPdroid sounds interesting. Can it handle m3u playlists out of the box?

@azathoth123
Copy link

azathoth123 commented Sep 18, 2019 via email

@SteveTalbot
Copy link
Contributor Author

MPD can handle m3u and other playlist formats out of the box, so any MPD client that supports playlists should be able to control playback of an mp3 collection with m3u files in the same directories. The change I made was to add support for playlists in the Volumio web interface.

@volumio: Is there anything I can do to help get this merged?

@volumio
Copy link
Owner

volumio commented Sep 19, 2019

@SteveTalbot Hi Steve, thanks. Yes, first thing is to handle the conflicts, so I can test it. thanks!

# Conflicts:
#	app/plugins/music_service/mpd/index.js
@SteveTalbot
Copy link
Contributor Author

Hey @volumio, sorry for the delay in turning this around. I've done the merge and updated the PR

@volumio
Copy link
Owner

volumio commented Oct 1, 2019

Hi @SteveTalbot, gave it a spin.
See my remarks ( I want to move forward with this, but need some more work):

  • Please refactor the PR in a way the changes are minimal, I spotted many removals\additions which will break things.
  • You've removed the iso playback facility, which we need (it's a feature used on some OEM builds):

If you can reduce the changes, and circumstantiate them only to handling playlists, I can move forward. Thanks

@SteveTalbot
Copy link
Contributor Author

From memory, MPD returns info about the tracks in an ISO file in a similar format to a playlist. I refactored the code to handle this into a single "parseMpdCommandResponse" function, which should work for ISOs and playlists. So the change probably looks bigger than it is.

Have I inadvertently removed or changed some functionality that's being called from outside the plugin? I tried to keep the external interface the same, but I wanted to make a change that would support all playlist/container formats recognized by MPD.

@volumio
Copy link
Owner

volumio commented Oct 3, 2019

@SteveTalbot sorry if I ask you to refactor, but from this PR is very hard to spot possible regressions. Please redo it in a very circumstantiated way that handles only playlist cases. Thanks for understanding

@SteveTalbot
Copy link
Contributor Author

Hi @volumio, I've refactored the changes so it should be easier for you to spot regressions. Can you give it another look please?

@mikelowndes
Copy link

This does not seem to have been implemented - what gives?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants