Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get-11 fix get-params for dynamic paths #12

Merged
merged 3 commits into from
Feb 18, 2024
Merged

get-11 fix get-params for dynamic paths #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11fb5f2
get-11 fix get-params for dynamic paths
vordgi Feb 18, 2024
bedbf97
get-11 update package version to v0.3.3
vordgi Feb 18, 2024
f5d77d2
get-11 improve get-params result validity check
vordgi Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "next-impl-getters",
"version": "0.3.2",
"version": "0.3.3",
"description": "Repo for an example implementation of getters to retrieve page data in react server components",
"files": [
"**/*.js",
Expand Down
4 changes: 3 additions & 1 deletion src/get-params.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ export const getParams = () => {

const isRootPage = cleanUrlPathname === '' && cleanPagePath === '';
const isNotFoundPage = pagePath.match(/\/_not-found\/?$/);
const isValidCatchALl = cleanPagePath.match(/\[\.\.\.[^\]]+\]/) && pathnameParts.length >= pagePathInterceptedParts.length;
const isCorrectMatched = isRootPage || isNotFoundPage || pagePathInterceptedParts.length === pathnameParts.length || isValidCatchALl;

if (!isRootPage && !isNotFoundPage && pagePathInterceptedParts.length !== pathnameParts.length) {
if (!isCorrectMatched) {
const createIssueUrl = new URL('https://github.com/vordgi/next-impl-getters/issues/new')
createIssueUrl.searchParams.set('title', 'Error parsing segments in get-params');
createIssueUrl.searchParams.set('body', `urlPathname: \`${urlPathname}\`;\n\npagePath: \`${pagePath}\`;`);
Expand Down