Fix authentification manager wrong if statement usage #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbonneau
reviewed
Jun 13, 2018
| @@ -224,7 +224,7 @@ public function handleHelloMessage(Realm $realm, Session $session, HelloMessage | |||
| } | |||
|
|
|||
| // If no authentication providers are registered for this realm send an abort message | |||
| if ($this->realmHasAuthProvider($realm->getRealmName())) { | |||
| if ($this->realmHasAuthProvider($realm->getRealmName()) === false) { | |||
There was a problem hiding this comment.
@Webonaute Has this actually caused an issue for you? realmHasAuthProver can only return a boolean:
Thruway/src/Authentication/AuthenticationManager.php
Lines 502 to 513 in 7039e87
There was a problem hiding this comment.
Read the comment just over the line than read the original if statement. :)
As soon as you set a auth it will never go in auth code under those line.
And somevar === false is lot more easy and clear to read than !somevar
There was a problem hiding this comment.
Link to my issue here voryx/ThruwayBundle#88
|
Nvm just read more. I wrong interpreted the next lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.