Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a function to extend the options used in the initial connection #52

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bondt
Copy link
Contributor

@bondt bondt commented Jun 14, 2016

And synced src/ and release/ .js files

For #45 :-)

@bondt
Copy link
Contributor Author

bondt commented Jun 14, 2016

@davidwdan if accepted, could you push a new release?

@davidwdan
Copy link
Member

@bondt I'm not clear on what the use case is for this? When would you need to change the connection options after the initial setup?

@bondt
Copy link
Contributor Author

bondt commented Jun 14, 2016

@davidwdan I am using wampcra for authentication. To allow the onchallenge handler to sign the request with the user's password, I am setting the onchallenge after the input.

Another use case is written in #45.

And finally I don't see why angular-wamp should limit autobahn's connection options to be set and managed freely.

@davidwdan
Copy link
Member

I'm not a big fan of being able to change the options after the service has been created. It's confusing and allowing the user to open and close the connection while changing the options is a separation of concerns issue.

If anything we should make it easier to create a new instance of the service without having to set options at bootstrap.

@bondt
Copy link
Contributor Author

bondt commented Jun 21, 2016

I agree with you on both terms, though I think the developer should be capable of managing this. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants