Uniswap tenant + a ton of multi-tenant upgrades #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of https://github.com/voteagora/agora-next into andrei/agora-1643-setup-agora-next-instance-of-uniswap
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mcgingras
reviewed
Jun 14, 2024
|
|
||
| votingPeriod?: TypedContractMethod<[], [bigint], "view">; | ||
|
|
||
| weightCast?: TypedContractMethod< |
There was a problem hiding this comment.
nice this was blowing up the scroll governor
mcgingras
reviewed
Jun 14, 2024
| @@ -2,6 +2,11 @@ import type { TypedContractMethod } from "@/lib/contracts/generated/common"; | |||
| import type { BaseContract, AddressLike } from "ethers"; | |||
|
|
|||
| export interface ITokenContract extends BaseContract { | |||
| allowance: TypedContractMethod< | |||
There was a problem hiding this comment.
is the point of these to just add the the functions that we use in the app so that way we can ensure the contracts we are using have the needed properties? bc these are surely not all of the functions on the contract.
another benefit to viem/wagmi is it typechecks against the abi so you don't have to do this
I feel like a painpoint here is you need to remember to update this file everything you add a block of code that calls a function not yet included here
mcgingras
reviewed
Jun 14, 2024
Comment on lines
+13
to
+14
| const TOKEN = "0xC18360217D8F7Ab5e7c516566761Ea12Ce7F9D72"; | ||
| const GOVERNOR = "0x0"; |
There was a problem hiding this comment.
I'd love to have isProd ? "0xProd" : "0xTest" for each tenant eventually
mcgingras
reviewed
Jun 14, 2024
| // Sepolia ETH | ||
| return `https://sepolia.etherscan.io/address/${address}`; | ||
|
|
||
| default: |
There was a problem hiding this comment.
are ens + uni on mainnet? are you just letting them fall through to default
andreitr
deleted the
andrei/agora-1643-setup-agora-next-instance-of-uniswap
branch
|
🔥🚀 |
kent
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Tenant scaffolding * OG image previews * More tenant config * Contract scaffolding * Misc * Staking route * Uniswap tenant db placehoder * Misc * Prettier * Misc * Generated * Staking contract scaffolding * Uni token and staker abis * Uni token and staker factoris * work in progress * WIP * Staking flow * Unstake flow dialog * Unstake flow * feat:Added Uni Staking UI/UX components * Uniswap UI implementation * Total staked * feat:uni staking select delegate ui/ux components * Wiring in the unstaking flow * Rewards metrics header * Prettier * Refactor ui components for uni staking * Work in progress * Merge * Delegate more flow * feat:staking transaction receipt ui/ux components * Additional delegations * Fixed dialog refresh * Fractional withdrawals * Work in progress * Implementing db calls * Replaced contract calls with db * wip Implementing deposit management flow * revamp:updated ui of claim reward component and transaction receipt * wip * Implementing ui in deposit / withdrawal flows * Prettier * Implemented new delegation flow * Misc * New deposit flow * Implementing UI on unistaker * Minor refactor of the delegate card component * Fixed pool stats * Withdraw refresh flow and component cleanup * Work in progress on editing deposit * Edit deposit and displayed sktaed amount per user * Unistaker * Unistaker flow update * More cleanup and bug bashing * Merge and bugfixes * Fixed delegate voting activity and build fixes * Alligator dependecny * Tenant abstracted delegation flow * Prettier * Resolved issue with scientific notation * Impelmenting abstract vote contract * Displaying transaction link and simplified button code * Prettier * Fixed a flicker issue with the deposit list * Deposit list padding * Disabled uniswap prop creation * Refactored deposits to work with static wallet paths * Misc * Misc refactor * Dynamic data refresh * Updated the FAQ page and disconnect page layout * Staking confirmation display * Invalidation strategy * Receipt background * Implemented allowance approval * Copy correction * QA fixes * Don't display duplicate delegate * Tenant svg icon * Display allowance and delegate icons * Tenant-based ens avatars * Fixed decimal rounding issue. * Fixed max amount bugs and disable deposit button when no balance * Refactored spending allowance flow * Minor styling fix * Abstract naming * Disabled proposal cancel for non-alligator tenants. Misc UI fixes * Minor cleanup and removed alligator requirement * Console log * Implemented chain-specific timestamps * Implemented tenant-specific quorum calculations * quorum votes for Uniswap governor * Split advanced voting from the basic voting * Linking proposed transactions to correct URLs * Merge * Merge with main * Tenant copy * Merge * Mainnet contracts and a small bugfix * Code review cleanup * staking page flag and metadata * Code review changes * Misc * minor code review * Code review fix --------- Co-authored-by: sbvhev <[email protected]> Co-authored-by: Andrei Taraschuk <[email protected]>
jefag
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Tenant scaffolding * OG image previews * More tenant config * Contract scaffolding * Misc * Staking route * Uniswap tenant db placehoder * Misc * Prettier * Misc * Generated * Staking contract scaffolding * Uni token and staker abis * Uni token and staker factoris * work in progress * WIP * Staking flow * Unstake flow dialog * Unstake flow * feat:Added Uni Staking UI/UX components * Uniswap UI implementation * Total staked * feat:uni staking select delegate ui/ux components * Wiring in the unstaking flow * Rewards metrics header * Prettier * Refactor ui components for uni staking * Work in progress * Merge * Delegate more flow * feat:staking transaction receipt ui/ux components * Additional delegations * Fixed dialog refresh * Fractional withdrawals * Work in progress * Implementing db calls * Replaced contract calls with db * wip Implementing deposit management flow * revamp:updated ui of claim reward component and transaction receipt * wip * Implementing ui in deposit / withdrawal flows * Prettier * Implemented new delegation flow * Misc * New deposit flow * Implementing UI on unistaker * Minor refactor of the delegate card component * Fixed pool stats * Withdraw refresh flow and component cleanup * Work in progress on editing deposit * Edit deposit and displayed sktaed amount per user * Unistaker * Unistaker flow update * More cleanup and bug bashing * Merge and bugfixes * Fixed delegate voting activity and build fixes * Alligator dependecny * Tenant abstracted delegation flow * Prettier * Resolved issue with scientific notation * Impelmenting abstract vote contract * Displaying transaction link and simplified button code * Prettier * Fixed a flicker issue with the deposit list * Deposit list padding * Disabled uniswap prop creation * Refactored deposits to work with static wallet paths * Misc * Misc refactor * Dynamic data refresh * Updated the FAQ page and disconnect page layout * Staking confirmation display * Invalidation strategy * Receipt background * Implemented allowance approval * Copy correction * QA fixes * Don't display duplicate delegate * Tenant svg icon * Display allowance and delegate icons * Tenant-based ens avatars * Fixed decimal rounding issue. * Fixed max amount bugs and disable deposit button when no balance * Refactored spending allowance flow * Minor styling fix * Abstract naming * Disabled proposal cancel for non-alligator tenants. Misc UI fixes * Minor cleanup and removed alligator requirement * Console log * Implemented chain-specific timestamps * Implemented tenant-specific quorum calculations * quorum votes for Uniswap governor * Split advanced voting from the basic voting * Linking proposed transactions to correct URLs * Merge * Merge with main * Tenant copy * Merge * Mainnet contracts and a small bugfix * Code review cleanup * staking page flag and metadata * Code review changes * Misc * minor code review * Code review fix --------- Co-authored-by: sbvhev <[email protected]> Co-authored-by: Andrei Taraschuk <[email protected]>
jefag
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Tenant scaffolding * OG image previews * More tenant config * Contract scaffolding * Misc * Staking route * Uniswap tenant db placehoder * Misc * Prettier * Misc * Generated * Staking contract scaffolding * Uni token and staker abis * Uni token and staker factoris * work in progress * WIP * Staking flow * Unstake flow dialog * Unstake flow * feat:Added Uni Staking UI/UX components * Uniswap UI implementation * Total staked * feat:uni staking select delegate ui/ux components * Wiring in the unstaking flow * Rewards metrics header * Prettier * Refactor ui components for uni staking * Work in progress * Merge * Delegate more flow * feat:staking transaction receipt ui/ux components * Additional delegations * Fixed dialog refresh * Fractional withdrawals * Work in progress * Implementing db calls * Replaced contract calls with db * wip Implementing deposit management flow * revamp:updated ui of claim reward component and transaction receipt * wip * Implementing ui in deposit / withdrawal flows * Prettier * Implemented new delegation flow * Misc * New deposit flow * Implementing UI on unistaker * Minor refactor of the delegate card component * Fixed pool stats * Withdraw refresh flow and component cleanup * Work in progress on editing deposit * Edit deposit and displayed sktaed amount per user * Unistaker * Unistaker flow update * More cleanup and bug bashing * Merge and bugfixes * Fixed delegate voting activity and build fixes * Alligator dependecny * Tenant abstracted delegation flow * Prettier * Resolved issue with scientific notation * Impelmenting abstract vote contract * Displaying transaction link and simplified button code * Prettier * Fixed a flicker issue with the deposit list * Deposit list padding * Disabled uniswap prop creation * Refactored deposits to work with static wallet paths * Misc * Misc refactor * Dynamic data refresh * Updated the FAQ page and disconnect page layout * Staking confirmation display * Invalidation strategy * Receipt background * Implemented allowance approval * Copy correction * QA fixes * Don't display duplicate delegate * Tenant svg icon * Display allowance and delegate icons * Tenant-based ens avatars * Fixed decimal rounding issue. * Fixed max amount bugs and disable deposit button when no balance * Refactored spending allowance flow * Minor styling fix * Abstract naming * Disabled proposal cancel for non-alligator tenants. Misc UI fixes * Minor cleanup and removed alligator requirement * Console log * Implemented chain-specific timestamps * Implemented tenant-specific quorum calculations * quorum votes for Uniswap governor * Split advanced voting from the basic voting * Linking proposed transactions to correct URLs * Merge * Merge with main * Tenant copy * Merge * Mainnet contracts and a small bugfix * Code review cleanup * staking page flag and metadata * Code review changes * Misc * minor code review * Code review fix --------- Co-authored-by: sbvhev <[email protected]> Co-authored-by: Andrei Taraschuk <[email protected]>
jefag
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Tenant scaffolding * OG image previews * More tenant config * Contract scaffolding * Misc * Staking route * Uniswap tenant db placehoder * Misc * Prettier * Misc * Generated * Staking contract scaffolding * Uni token and staker abis * Uni token and staker factoris * work in progress * WIP * Staking flow * Unstake flow dialog * Unstake flow * feat:Added Uni Staking UI/UX components * Uniswap UI implementation * Total staked * feat:uni staking select delegate ui/ux components * Wiring in the unstaking flow * Rewards metrics header * Prettier * Refactor ui components for uni staking * Work in progress * Merge * Delegate more flow * feat:staking transaction receipt ui/ux components * Additional delegations * Fixed dialog refresh * Fractional withdrawals * Work in progress * Implementing db calls * Replaced contract calls with db * wip Implementing deposit management flow * revamp:updated ui of claim reward component and transaction receipt * wip * Implementing ui in deposit / withdrawal flows * Prettier * Implemented new delegation flow * Misc * New deposit flow * Implementing UI on unistaker * Minor refactor of the delegate card component * Fixed pool stats * Withdraw refresh flow and component cleanup * Work in progress on editing deposit * Edit deposit and displayed sktaed amount per user * Unistaker * Unistaker flow update * More cleanup and bug bashing * Merge and bugfixes * Fixed delegate voting activity and build fixes * Alligator dependecny * Tenant abstracted delegation flow * Prettier * Resolved issue with scientific notation * Impelmenting abstract vote contract * Displaying transaction link and simplified button code * Prettier * Fixed a flicker issue with the deposit list * Deposit list padding * Disabled uniswap prop creation * Refactored deposits to work with static wallet paths * Misc * Misc refactor * Dynamic data refresh * Updated the FAQ page and disconnect page layout * Staking confirmation display * Invalidation strategy * Receipt background * Implemented allowance approval * Copy correction * QA fixes * Don't display duplicate delegate * Tenant svg icon * Display allowance and delegate icons * Tenant-based ens avatars * Fixed decimal rounding issue. * Fixed max amount bugs and disable deposit button when no balance * Refactored spending allowance flow * Minor styling fix * Abstract naming * Disabled proposal cancel for non-alligator tenants. Misc UI fixes * Minor cleanup and removed alligator requirement * Console log * Implemented chain-specific timestamps * Implemented tenant-specific quorum calculations * quorum votes for Uniswap governor * Split advanced voting from the basic voting * Linking proposed transactions to correct URLs * Merge * Merge with main * Tenant copy * Merge * Mainnet contracts and a small bugfix * Code review cleanup * staking page flag and metadata * Code review changes * Misc * minor code review * Code review fix --------- Co-authored-by: sbvhev <[email protected]> Co-authored-by: Andrei Taraschuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buckle up, this PR is massive! Please take the time to look through the changes and understand the code 🙏
Staking
The functionality is encapsulated under the
/stakingroute and should not affect the rest of the application.Multi-tenant
The changes have an impact across the board:
PR-Codex overview
This PR updates font styles, adds new tenant namespaces, changes API key initialization, introduces new dependencies, adjusts contract methods, and enhances UI components.
Detailed summary
OPProposalPage.module.scssUNISWAPagoraAPI.js@radix-ui/react-checkboxdependencyITokenContract.tsReceiptContainer.tsxandStakingIntro.tsx