Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 add mocked route for ballots #244

Merged
merged 7 commits into from
Apr 22, 2024
Merged

Conversation

Flip-Liquid
Copy link
Collaborator

@Flip-Liquid Flip-Liquid commented Apr 22, 2024

PR-Codex overview

The focus of this PR is to update the RetroFunding API endpoints related to fetching and submitting ballots. It includes adding routes for fetching and submitting specific ballots based on round ID and caster address/ENS.

Detailed summary

  • Added routes for fetching and submitting specific ballots based on round ID and caster address/ENS
  • Updated API functions to fetch individual ballots based on round ID and caster address/ENS
  • Renamed parameters in OpenAPI spec to reflect the caster address instead of ballot address/ENS

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agora-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 10:38pm
agora-next-ens ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 10:38pm
agora-next-etherfi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 10:38pm

@Flip-Liquid
Copy link
Collaborator Author

did a pass after correcting that naming @stepandel, plz take another look when you have a chance

Copy link
Contributor

@stepandel stepandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works!

@Flip-Liquid Flip-Liquid merged commit c9185cb into main Apr 22, 2024
6 checks passed
@Flip-Liquid Flip-Liquid deleted the flip/mocked_ballots_routes branch April 22, 2024 22:52
kent pushed a commit that referenced this pull request Aug 30, 2024
* 💻 add mocked route for ballots
* 💻 add ballot-by-address route and ✌️query ✌️
* 💻🤏📐 return body of ballot for /submit
* 🔁🏷️ feedback: rename ballotAddress to balltotCasterAddress
* 🔁💻🏷️ unify ballot address + submitter fields to ballotCasterAddress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants