Fixes duplicate twitter metadata #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kent
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Confirmed by inspecting OG in Vercel: https://vercel.com/voteagora/agora-next/8L2j1eZrWRPtctxsEn7VznAjX5VD/og
mcgingras
deleted the
michael/agora-1872-metatags-like-twittercard-are-displayed-twice
branch
kent
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Fixes duplicate twitter metadata * Removes stale code from root page metadata generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves AGORA-1872
Fairly certain this resolves it, it was resolving the issue on local.
Once this PR builds on vercel we can test by inspecting the metadata and OG previews.
PR-Codex overview
This PR updates the structure of Twitter metadata in multiple page components to use a nested
twitterobject.Detailed summary
page.jsx,page.tsx, and other related filestwitterobject for consistency