Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swagger fixups #252

Merged
merged 6 commits into from
Apr 23, 2024
Merged

swagger fixups #252

merged 6 commits into from
Apr 23, 2024

Conversation

Flip-Liquid
Copy link
Contributor

@Flip-Liquid Flip-Liquid commented Apr 23, 2024

  • Ensure base api url is not duplicated in swagger ui
  • Handle bearer token format

PR-Codex overview

The focus of this PR is to update URLs, improve error messages, and refactor token extraction in authentication middleware.

Detailed summary

  • Updated base URL in spec/oas_v1.yaml
  • Improved error message in src/app/lib/middleware/auth.ts
  • Refactored token extraction logic in authentication middleware

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agora-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 2:17am
agora-next-ens ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 2:17am
agora-next-etherfi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 2:17am

@Flip-Liquid Flip-Liquid merged commit 9d3f38b into main Apr 23, 2024
6 checks passed
@Flip-Liquid Flip-Liquid deleted the flip/swagger_fixups branch April 23, 2024 02:29
kent pushed a commit that referenced this pull request Aug 30, 2024
* 🤏💻 fix url for swagger ui
* 🔐 auth fixups for validating bearer token
* 🤏🔐 typo in error msg
jefag pushed a commit that referenced this pull request Oct 4, 2024
* 🤏💻 fix url for swagger ui
* 🔐 auth fixups for validating bearer token
* 🤏🔐 typo in error msg
jefag pushed a commit that referenced this pull request Oct 4, 2024
* 🤏💻 fix url for swagger ui
* 🔐 auth fixups for validating bearer token
* 🤏🔐 typo in error msg
jefag pushed a commit that referenced this pull request Oct 8, 2024
* 🤏💻 fix url for swagger ui
* 🔐 auth fixups for validating bearer token
* 🤏🔐 typo in error msg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants