Fazle/vote timeline chart

[sbvhev]

PR-Codex overview

This PR introduces new SVG icons for voting bars, updates component props, adds scientific notation functions, and refactors UI components.

Detailed summary

• Added new SVG icons for voting bars
• Updated component props to include proposalVotes
• Added scientific notation functions
• Refactored UI components for better structure

The following files were skipped due to too many changes: src/components/Proposals/ProposalPage/OPProposalPage/ProposalVotesSummary/ProposalVotesSummary.tsx, src/components/Proposals/ProposalPage/VotingTimelineChart/VotingTimelineChart.tsx, src/components/Proposals/ProposalPage/OPProposalPage/ProposalVotesSummaryDetails/ProposalVotesSummaryDetails.tsx, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
agora-next	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 12, 2024 10:11pm
agora-next-ens	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 12, 2024 10:11pm
agora-next-etherfi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 12, 2024 10:11pm
agora-next-uniswap	❌ Failed (Inspect)			Jun 12, 2024 10:11pm

[sweep-ai]

Sweep: PR Review

Authors of pull request: @sbvhev

src/components/Proposals/ProposalPage/OPProposalApprovalPage/OPProposalApprovalPage.tsx

Added a new prop proposalVotes to the ProposalDescription component to provide it with votes data fetched asynchronously.

Sweep Found These Issues

• The fetchProposalVotes function is called without error handling, which could lead to unhandled promise rejections if the API call fails.

agora-next/src/components/Proposals/ProposalPage/OPProposalApprovalPage/OPProposalApprovalPage.tsx

Line 56 in e1d726a

const proposalVotes = await fetchProposalVotes(proposal.id);


View Diff

---

src/components/Proposals/ProposalPage/OPProposalPage/OPProposalOptimisticPage.jsx

Added the proposalVotes prop to the ProposalDescription component to enable it to utilize votes data.

Sweep Found These Issues

• The proposalVotes prop is added to ProposalDescription without verifying if the component is updated to handle this new prop, which could lead to potential runtime errors if not handled properly.

agora-next/src/components/Proposals/ProposalPage/OPProposalPage/OPProposalOptimisticPage.jsx

Line 87 in e1d726a

<ProposalDescription proposalVotes={proposalVotes} proposal={proposal} />


View Diff

---

src/components/Proposals/ProposalPage/OPProposalPage/OPProposalPage.tsx

Added the proposalVotes prop to the ProposalDescription component to provide it with voting data.

---

src/components/Proposals/ProposalPage/OPProposalPage/ProposalVotesSummary/ProposalVotesSummary.tsx

Added hover card functionality to display detailed proposal vote summaries on hover.

Sweep Found These Issues

• The showDetails state variable is not reset to false when the hover card is closed, which could lead to unexpected behavior if the component is re-rendered.

agora-next/src/components/Proposals/ProposalPage/OPProposalPage/ProposalVotesSummary/ProposalVotesSummary.tsx

Lines 22 to 32 in e1d726a

	const [showDetails, setShowDetails] = useState(false);
	const results =
	proposal.proposalResults as ParsedProposalResults["STANDARD"]["kind"];
	return (
	<HoverCard
	open={showDetails}
	onOpenChange={setShowDetails}
	openDelay={400}
	closeDelay={600}
	>


View Diff

---

src/components/Proposals/ProposalPage/ProposalDescription/ProposalDescription.jsx

Added the VotingTimelineChart component to the ProposalDescription component to display a voting timeline using the proposal and proposalVotes props.

Sweep Found These Issues

• The proposalVotes prop is added to the ProposalDescription component, but there is no validation or default value handling for this new prop, which could lead to runtime errors if it is undefined or null.

agora-next/src/components/Proposals/ProposalPage/ProposalDescription/ProposalDescription.jsx

Line 11 in e1d726a

export default function ProposalDescription({ proposal, proposalVotes }) {


View Diff

---

src/icons/icons.ts

Added three new SVG icons (chevronSelectorVertical, check, and link) to the icons export object.

---

src/lib/utils.ts

Added a new function formatNumberWithScientificNotation for scientific notation formatting and ensured consistent BigInt operations in generateBarsForVote.

Sweep Found These Issues

• The formatNumberWithScientificNotation function does not handle cases where the input x is not a number, which could result in unexpected behavior or errors.

agora-next/src/lib/utils.ts

Lines 81 to 96 in e1d726a

	export function formatNumberWithScientificNotation(x: any) {
	if (Math.abs(x) < 1.0) {
	var e = parseInt(x.toString().split("e-")[1]);
	if (e) {
	x *= Math.pow(10, e - 1);
	x = "0." + new Array(e).join("0") + x.toString().substring(2);
	}
	} else {
	var e = parseInt(x.toString().split("+")[1]);
	if (e > 20) {
	e -= 20;
	x /= Math.pow(10, e);
	x += new Array(e + 1).join("0");
	}
	}
	return x;


View Diff

---

The following files were not reviewed because our filter identified them as typically non-human-readable or less important files (e.g., dist files, package.json, images). If this is an error, please let us know.

• package.json
• yarn.lock

[andreitr]

The chart looks good for optimism but we need to figure out why it didn't work on ENS proposals.