Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Images download hotfix #1151

Merged
merged 6 commits into from
Jul 31, 2021
Merged

Open Images download hotfix #1151

merged 6 commits into from
Jul 31, 2021

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Jul 31, 2021

Fixes a bug where label files were not being downloaded when running a load_zoo_dataset() call that does not include classes or attrs options in an environment where Open Images has never been downloaded:

import fiftyone.zoo as foz

foz.delete_zoo_dataset("open-images-v6", split="validation")

# previously would fail, now succeeds
dataset = foz.load_zoo_dataset("open-images-v6", split="validation", max_samples=5)

@brimoor brimoor added the hotfix A hot fix to production. Act fast label Jul 31, 2021
@brimoor brimoor requested a review from a team July 31, 2021 15:00
@brimoor brimoor added the bug Bug fixes label Jul 31, 2021
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminpkane benjaminpkane merged commit e26490d into develop Jul 31, 2021
@benjaminpkane benjaminpkane deleted the oi-fix branch July 31, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes hotfix A hot fix to production. Act fast
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants