Add keyboard shortcut to temporarily hide all labels in the App #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritch
commented
May 25, 2022
ritch
commented
May 25, 2022
ritch
commented
May 25, 2022
ritch
force-pushed
the
feat-1761
branch
4 times, most recently
from
1315230
to
c01def1
Compare
ritch
changed the title
ritch
added
feature
benjaminpkane
approved these changes
Jun 1, 2022
| this.element.src = ICONS.overlaysHidden; | ||
| } else { | ||
| this.element.title = `Show all overlays (h)`; | ||
| this.element.classList.add(lookerControlActive); |
There was a problem hiding this comment.
Maybe reverse the icons? It looks like the strike through icon is shown when labels are visible. I would have thought that means they are hidden.
|
Couple things I saw while testing:
|
|
Fixed the issues mentioned above. This should be ready to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See background in #1761.
This feature adds the ability to temporarily hide all overlays/tooltips by pressing the "Shift" key. This is supported while viewing samples in the
Lookermodal image and video modes.Specifically this adds:
LookerLookercontrolsAtomfor persisting the show/hide overlay value in recoilLookerand recoil (based on fullscreen)To implement a control with "hold" supprt, you must specify it's
ControlEventKeyTypesasHOLDas well as add a new method:control.afterAction(). ThisafterActionmethod will be called onkeyupallowing for the control to make updates after the user depresses the key.NOTE: in a typical hold event model I would usually debounce the keydown event. I've left that optimization out, if we notice performance issues we can look into adding that or something similar.