Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection and expansion for bad media files #1882

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

benjaminpkane
Copy link
Contributor

Resolves #1865

import fiftyone as fo

dataset = fo.Dataset("bad")
sample = fo.Sample(filepath="bad.png")  
dataset.add_sample(sample)

# image
session = fo.Session(dataset)

dataset = fo.Dataset("bad-video")
sample = fo.Sample(filepath="bad.mp4")  
dataset.add_sample(sample)

# video
session.dataset = dataset

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features labels Jun 13, 2022
@benjaminpkane benjaminpkane self-assigned this Jun 13, 2022
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminpkane benjaminpkane merged commit 9480a21 into develop Jun 16, 2022
@benjaminpkane benjaminpkane deleted the bugfix/iss-1865 branch June 16, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Issues related to App features bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot select sample with error in grid
2 participants