Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ipywidgets<8 requirement #2011

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Adding ipywidgets<8 requirement #2011

merged 1 commit into from
Aug 23, 2022

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Aug 21, 2022

ipywidgets==8.0.0 was released August 18th, but unfortunately it looks like it is not compatible with plotly<=5.9.0, as the following error is raised (confirmed locally):

AttributeError: type object 'DOMWidget' has no attribute '_ipython_display_'

Therefore, this PR adds an ipywidgets<8 requirement to FiftyOne.

@brimoor brimoor added the documentation Documentation work label Aug 21, 2022
@brimoor brimoor requested a review from a team August 21, 2022 17:34
@brimoor brimoor self-assigned this Aug 21, 2022
benjaminpkane
benjaminpkane approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor brimoor merged commit b7f7a41 into develop Aug 23, 2022
@brimoor brimoor deleted the bugfix/ipywidgets branch August 23, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminpkane benjaminpkane benjaminpkane approved these changes

Assignees

@brimoor brimoor

Labels
documentation Documentation work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brimoor @benjaminpkane