common json panel for 2d/3d lookers #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminpkane
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Smooth. LGTM!
Small comments:
- opacity differs from Looker2d's shortcuts panel
- Looker3d HUD actions don't have titles/tooltips
- I noticed that the active sample can change with JSON open, but that JSON data does not change with it. Maybe it can change with it?
I will open a PR cleaning up the old implemntation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the JSON panel for use in both 2d/3d lookers.