Don't include runs when merging collections #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brimoor
commented
Aug 26, 2022
| curr_fields = self.get_field_schema() | ||
| add_field_fcn = self.add_sample_field | ||
| self._apply_schema(curr_fields, new_fields, add_field_fcn) | ||
| for field_name, field_str in new_fields.items(): |
There was a problem hiding this comment.
Also removed the unused curr_fields argument in these two functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
add_samples()andadd_collection()had logic in-place to merge annotation/brain/evaluation runs into the destination dataset, but that doesn't make sense as runs are only valid for the particularviewon which they were applied, which will not be the same (in general) when merging datasets.There was already logic in-place to prevent merges when the destination dataset was non-empty, but there wasn't any logic to prevent runs from being merged when the source collection was a view, not a full dataset, which was definitely a bug. So the only valid use case is:
but that is better expressed as:
So, I just removed this code :)