Looker3d hotkeys #2032
Merged
Looker3d hotkeys #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritch
force-pushed
the
looker3d-hotkeys
branch
from
c694928
to
dda2a84
Compare
|
Just tested this branch and documented a few issues I found in our punch list doc |
ritch
force-pushed
the
looker3d-hotkeys
branch
2 times, most recently
from
12be7fb
to
1e82ba3
Compare
ritch
force-pushed
the
looker3d-hotkeys
branch
from
76d47ec
to
57313cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New HelpPanel
Adds a new generic react HelpPanel which displays shortcuts/help items. These are provided by the component using the
useHelpPanelhook, which allows the content / rendering/component to exist in totally different context.However this does not replace the support for the existing Looker Help Panel. That should be possible in the future. This is only used in the 3d looker at the moment.
Hot Key Support for Looker3D
This tries to mimic the exact logic/style of Escape and other shortcuts in the 2d looker.
Known Issue
If you hover over the 2d looker while a panel (eg. JSONPanel) is open, pressing escape will both close the JSONPanel and the entire Modal. This is due to the common "reading state in an event bug" where the state is actually the initially rendered state. However fixing this is non trivial and should be taken on as a follow up.