Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rel_dir to export() and draw_labels() #2060

Merged
merged 12 commits into from
Sep 8, 2022
Merged

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Sep 2, 2022

Resolves #2000

Other goodies:

  • Added a rel_dir parameter on draw_labels() and export()---as well as all builtin exporters---which allows for the possibility of preserving nested subdirectory structure of the input dataset's media
  • Adds an optional abs_paths parameter to all relevant exporters that allows for storing absolute paths to media in the exported labels

@brimoor brimoor added the bug Bug fixes label Sep 2, 2022
@brimoor brimoor requested review from ehofesmann and a team September 2, 2022 22:09
@brimoor brimoor self-assigned this Sep 2, 2022
@brimoor brimoor marked this pull request as draft September 2, 2022 22:10
@brimoor brimoor changed the title [WIP] Adding rel_dir to export() and draw_labels() Adding rel_dir to export() and draw_labels() Sep 8, 2022
@brimoor brimoor marked this pull request as ready for review September 8, 2022 01:02
Copy link
Member

@ehofesmann ehofesmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brimoor brimoor merged commit 6e6d389 into develop Sep 8, 2022
@brimoor brimoor deleted the bugfix/iss-2000 branch September 8, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unique filenames are not generated when drawing labels
2 participants