-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style fixes and add header and sidebar bg token #2157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanjra
changed the title
style fixes and add header and sidebar bg token
[WIP] style fixes and add header and sidebar bg token
Oct 12, 2022
imanjra
force-pushed
the
feature/theming-ben-im
branch
from
October 14, 2022 15:14
4a5016d
to
a0e094b
Compare
imanjra
force-pushed
the
feature/theming-ben-im
branch
from
October 14, 2022 16:00
bd0cda7
to
4671fa8
Compare
imanjra
force-pushed
the
feature/theming-ben-im
branch
from
October 14, 2022 16:20
4671fa8
to
f5cc4d0
Compare
imanjra
added
app
Issues related to App features
design
Work related to the design of a feature/UI element
labels
Oct 14, 2022
@imanjra nice work! 🥇 Here's my reactions: General
Light theme
|
imanjra
force-pushed
the
feature/theming-ben-im
branch
from
October 17, 2022 22:58
b0879be
to
b9005a0
Compare
benjaminpkane
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Made a couple small tweaks.
benjaminpkane
changed the title
[WIP] style fixes and add header and sidebar bg token
style fixes and add header and sidebar bg token
Oct 27, 2022
benjaminpkane
added a commit
that referenced
this pull request
Oct 27, 2022
* work * initial theme pass * tweaks * edits * bugs * theme tweaks * fix * fix * tweaks * wrap dataset container with ThemeContext when a theme prop is provided * prevent passing value prop to Fragment * wrap test app with ThemeProvider * fix view bar crash * import updates * mui theme * update yarn * query typo * case change * proposal * style fixes and add header and sidebar bg token (#2157) * style fixes and add header and sidebar bg token * cleanup theme provider * update theme override support * fix font family issue * fix generated query for path * light theme fixes first pass * add theme toggle button * use app theme for default map theme * theme and style fixes first pass * theme mode and compact layout prop support * fix button tooltip font size issue * use lighter dynamic color as bg for active filter * light theme fixes second pass * use svg element instead of img for looker controls * add toggle to show or hide outer container header * looker style enhancements first pass * merge * cleaning * fix * fix query Co-authored-by: Benjamin Kane <[email protected]> * update query * update deps * fix merge Co-authored-by: imanjra <[email protected]>
manivoxel51
pushed a commit
that referenced
this pull request
Nov 8, 2022
* work * initial theme pass * tweaks * edits * bugs * theme tweaks * fix * fix * tweaks * wrap dataset container with ThemeContext when a theme prop is provided * prevent passing value prop to Fragment * wrap test app with ThemeProvider * fix view bar crash * import updates * mui theme * update yarn * query typo * case change * proposal * style fixes and add header and sidebar bg token (#2157) * style fixes and add header and sidebar bg token * cleanup theme provider * update theme override support * fix font family issue * fix generated query for path * light theme fixes first pass * add theme toggle button * use app theme for default map theme * theme and style fixes first pass * theme mode and compact layout prop support * fix button tooltip font size issue * use lighter dynamic color as bg for active filter * light theme fixes second pass * use svg element instead of img for looker controls * add toggle to show or hide outer container header * looker style enhancements first pass * merge * cleaning * fix * fix query Co-authored-by: Benjamin Kane <[email protected]> * update query * update deps * fix merge Co-authored-by: imanjra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR continuous theming refresh PR #2156 in ways listed below:
How is this patch tested? If it is not, please explain why.
[WIP] As the changes in this PR are related to the UI of the app, it will be tested visually
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
Several color and layout style of the application are being updated. Additionally, a light theme is being added along with a toggle (in the top right) to switch between dark and light theme.
What areas of FiftyOne does this PR affect?
fiftyone
Python library changes