Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB config cleanup #2179

Merged
merged 2 commits into from
Oct 17, 2022
Merged

DB config cleanup #2179

merged 2 commits into from
Oct 17, 2022

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Oct 15, 2022

Change log

  • Updates the docs to clarify that FiftyOne only requires MongoDB v4.4 or later
  • Removes the v0.7.1 "admin" migration. In general editing past migrations is 👎, but this migration wasn't actually required and we shouldn't be automating things that require admin database permissions

@brimoor brimoor added documentation Documentation work cleaning Code cleaning labels Oct 15, 2022
@brimoor brimoor requested a review from a team October 15, 2022 15:18
@brimoor brimoor self-assigned this Oct 15, 2022
kaixi-wang
kaixi-wang approved these changes Oct 16, 2022
View reviewed changes
Copy link
Contributor

@kaixi-wang kaixi-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brimoor brimoor merged commit 4dbe4a0 into develop Oct 17, 2022
@brimoor brimoor deleted the db-cleanup branch October 17, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaixi-wang kaixi-wang kaixi-wang approved these changes

Assignees

@brimoor brimoor

Labels
cleaning Code cleaning documentation Documentation work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brimoor @kaixi-wang